Re: [coreboot] New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings

[Vikram Narayanan]

Hello Paul,

On 26-Jan-12 1:33 PM, Paul Menzel wrote:

Dear Vikram,


thank you for your work and the patch.

Am Donnerstag, den 26.01.2012, 07:42 +0100 schrieb Vikram Narayanan:

[snip]

instead of almost duplicating the commit summary in the body could you
merge both and maybe paste the warning into the commit message.

     dumpmmcr: Fix compilation warnings in printf

     • cf. `man 3 printf`

You should be able to use `git commit --amend` to update the commit
message. That would be awesome.

Done. Uploaded the new patch. Thanks for your comments.

Thanks,
Vikram

Thanks,

Paul

--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot