Zheng Bao ([email protected]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/902
-gerrit commit 6a7857a7b7f69b7979886598a31da0fdeeb8b4c3 Author: zbao <[email protected]> Date: Tue Apr 17 11:33:27 2012 +0800 Do not produce temp s3.rom if HAVE_ACPI_RESUME is no. s3.rom is useless for all the other boards which S3 resume is not validated. Yes, sooner or later when CBFS is able to allocated an area, the s3.rom is no longer needed. But currently, other boards don't want to be bothered. It is not just for AGESA. AFAICS, all AMD boards need it. This feature, I believe, is needed by all the later boards which support S3 resume. It will be moved to a upper level folder then. Change-Id: I12693e9556ca6f8e0d80b2ab2dca5c85bdb97685 Signed-off-by: Zheng Bao <[email protected]> Signed-off-by: zbao <[email protected]> --- src/southbridge/amd/Makefile.inc | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc index 2cdca29..01675ac 100644 --- a/src/southbridge/amd/Makefile.inc +++ b/src/southbridge/amd/Makefile.inc @@ -15,14 +15,16 @@ subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += cimx subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB800) += cimx subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB900) += cimx +ifeq ($(CONFIG_HAVE_ACPI_RESUME), y) + $(obj)/s3.rom: echo " S3 NVRAM 0xffff0000 (S3 storage area)" echo -ne '\xFF' > $@ for ((i=0;i<20479;i++)) do echo -ne '\xFF' >> $@ ; done -ifeq ($(CONFIG_HAVE_ACPI_RESUME), y) cbfs-files-y += s3nv s3nv-file := $(obj)/s3.rom s3nv-position := 0xffff0000 s3nv-type := raw -endif + +endif # CONFIG_HAVE_ACPI_RESUME == y -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
