Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
2 new defect(s) introduced to coreboot found with Coverity Scan.
334 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1353736: Control flow issues (NO_EFFECT)
/3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/plat_pm.c: 386 in
plat_affinst_suspend()
________________________________________________________________________________________________________
*** CID 1353736: Control flow issues (NO_EFFECT)
/3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/plat_pm.c: 386 in
plat_affinst_suspend()
380
381 mmio_write_32(rv, sec_entrypoint);
382
383 if (afflvl < MPIDR_AFFLVL2)
384 spm_mcdi_prepare_for_off_state(mpidr, afflvl);
385
>>> CID 1353736: Control flow issues (NO_EFFECT)
>>> This greater-than-or-equal-to-zero comparison of an unsigned value is
>>> always true. "afflvl >= 0U".
386 if (afflvl >= MPIDR_AFFLVL0)
387 mt_platform_save_context(mpidr);
388
389 /* Perform the common cluster specific operations */
390 if (afflvl >= MPIDR_AFFLVL1) {
391 /* Disable coherency if this cluster is to be turned
off */
** CID 1353737: Control flow issues (NO_EFFECT)
/3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/plat_pm.c: 459 in
plat_affinst_suspend_finish()
________________________________________________________________________________________________________
*** CID 1353737: Control flow issues (NO_EFFECT)
/3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/plat_pm.c: 459 in
plat_affinst_suspend_finish()
453 /* Perform the common cluster specific operations */
454 if (afflvl >= MPIDR_AFFLVL1) {
455 /* Enable coherency if this cluster was off */
456 plat_cci_enable();
457 }
458
>>> CID 1353737: Control flow issues (NO_EFFECT)
>>> This greater-than-or-equal-to-zero comparison of an unsigned value is
>>> always true. "afflvl >= 0U".
459 if (afflvl >= MPIDR_AFFLVL0)
460 mt_platform_restore_context(mpidr);
461
462 if (afflvl < MPIDR_AFFLVL2)
463 spm_mcdi_finish_for_on_state(mpidr, afflvl);
464
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/coreboot?tab=overview
To manage Coverity Scan email notifications for "coreboot@coreboot.org", click
https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&token=49533df725f93b78361afb7b89ccde93
--
coreboot mailing list: coreboot@coreboot.org
https://www.coreboot.org/mailman/listinfo/coreboot
