On Mon, Jul 11, 2016 at 3:19 PM, Aaron Durbin <adur...@google.com> wrote: > Hello, > > I have a historical question regarding the current selfboot.c > implementation surrounding PAYLOAD_SEGMENT_BSS. > > Documentation/cbfs.txt indicates that PAYLOAD_SEGMENT_BSS should be cleared: > > "PAYLOAD_SEGMENT_BSS 0x20535342 The memory speicfied by the > segment should be zeroed" > > And we have code which looks for partial segments backed by file > contents that zeros the memory that the file contents don't cover. > > But I don't see anywhere where we actually honor PAYLOAD_SEGMENT_BSS > by zero'ing the memory covered by it. > > Is this an oversight or is it explicitly not done, but no reasoning is > documented? > > Given the current semantics I think this memory region should be cleared. >
Patch pushed: https://review.coreboot.org/15603 > -Aaron -- coreboot mailing list: coreboot@coreboot.org https://www.coreboot.org/mailman/listinfo/coreboot
