Sound's like a good plan. On Sun, 2019-02-10 at 13:26 +0100, Arthur Heymans wrote: > Hi > > Currently most x86 platforms have CONFIG_NO_CAR_GLOBAL_MIGRATION set > by > implementing POSTCAR_STAGE. This means that global variables during > CAR > stages don't need to be migrated to cbmem when initializing cbmem, as > stages are cleanly separated programs (in other words you don't tear > down CAR while running code in CAR). Previously we had a CAR_GLOBAL > macro that would put global variables a 'special' place in car. with > NO_CAR_GLOBAL_MIGRATION this is not needed anymore. > > I propose to remove all those CAR_GLOBAL references on platforms > already > implementing POSTCAR_STAGE. see [1]. That way future platforms that > tend > to copy a lot of this code don't needlessly end up using this > meaningless macro. > > Now moving forward it would be a nice goal to set for the October > release 2020 to have NO_CAR_GLOBAL_MIGRATION as a mandatory feature? > This was already discussed in [2], without a decisive conclusion. > > [1]https://review.coreboot.org/q/topic:%2522no_CAR_GLOBAL%2522+ > [2] > https://mail.coreboot.org/hyperkitty/list/[email protected]/message/VJ34MNXVZRO4VUZAK2YXUMTBRFWNF7NM/ > _______________________________________________ > coreboot mailing list -- [email protected] > To unsubscribe send an email to [email protected] -- Patrick Rudolph
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: [email protected] Phone: +49 234 68 94 188 Sitz der Gesellschaft: Bochum Handelsregister: Amtsgericht Bochum, HRB 17519 Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
