Has anything changed with the syntax highlighting on Gerrit recently? I'm seeing many function parameters in orange (which is hard to read on a green background), and signs that it misparsed the code somehow (e.g. coloring opening braces different than closing ones). Example attached.
Yeah, something seems broken with how it's parsing, and orange is not a great color to use on a green background anyway. Here is an example where a function's return type is highlighted in orange rather than the usual purple: https://review.coreboot.org/c/coreboot/+/30414/22/src/mainboard/facebook/fbg1701/gpio.c#250 Here is an example where a variable is highlighted in orange while its type is purple (and the function return type is also purple, unlike in the previous example): https://review.coreboot.org/c/coreboot/+/30414/22/src/mainboard/facebook/fbg1701/acpi_tables.c Wanna file a bug at https://bugs.chromium.org/p/gerrit/issues/list ? ________________________________ From: Julius Werner <jwer...@chromium.org> Sent: Monday, April 22, 2019 5:06:03 PM To: Coreboot; Patrick Georgi Subject: [coreboot] Syntax highlighting screwed up (orange function parameters)? Has anything changed with the syntax highlighting on Gerrit recently? I'm seeing many function parameters in orange (which is hard to read on a green background), and signs that it misparsed the code somehow (e.g. coloring opening braces different than closing ones). Example attached.
_______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
