Hi Persmule, On Thu, Jul 16, 2020 at 5:17 PM Persmule <persm...@hardenedlinux.org> wrote: > > Hi Angel Pons, > > It seems that we may copy ec/lenovo/h8 to ec/lenovo/mec16xx ( or separate > directory for different chips ) to start dedicated support to them, since > though they are different, their behavior are so similar that code for > ec/lenovo/h8 can work on them, though buggy.
Nope. While it happens rather often, copying code to support a new chip is a terrible approach. Things get duplicated and get patched up independently, and then there are five copies of some file which only differ in cosmetics. If one wants to properly support the different ECs Lenovo uses on the Thinkpads, it's better to reverse engineer each platform again and add fresh code that is tested and known working. One also needs to remember that ECs are made of both hardware and software, and I doubt that any distinction is made in the case of ec/lenovo/h8. In case the software interface is the exact same for Lenovo laptops with different ECs, it should not go into either EC folder. > Best regards, > Persmule > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Thursday, July 16, 2020 5:10 PM, Angel Pons <th3fan...@gmail.com> wrote: > > > Hi Persmule, > > > > On Thu, Jul 16, 2020 at 5:02 PM Persmule persm...@hardenedlinux.org wrote: > > > > > Hi Angel Pons, > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > > On Thursday, July 16, 2020 2:47 PM, Angel Pons th3fan...@gmail.com wrote: > > > > > > > I suspect that reusing the H8 EC code for the xx30 series Thinkpads is > > > > a source of bugs. There isn't any H8 EC on those mainboards anymore, > > > > the EC was replaced with a completely different SMSC MEC1619. The > > > > T440p port seems to have a few bugs which might be due to the > > > > different EC. > > > > > > Is the EC on the xx20 series Thinkpads (e.g. X220) an H8 EC or not? > > > > AFAIK, yes. The specific H8S model used varies, but they are similar. > > I re-checked the T440p and it uses a different SMSC MEC1633L EC. That > > would explain why only the T440p had some weird issues regarding EC > > stuff. > > > > Best regards, > > Angel Regards, Angel _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
