Issue #460 has been updated by Nicholas Chin.
akjuxr3 akjuxr3 wrote in #note-1: > I vote against renaming any x7x board to ivybridge. Ivybridge is the CPU you > put into the x7x board. Not the board itself. > If you put a sandybridge CPU into the socket of the h77pro4-m, then its still > ivybridge? No. > If you put a ivybridge CPU into a Thinkpad T420 (coreboot add support for > ivybridge) is it then suddenly ivybridge? More likely, but still not really. While I don't disagree with this sentiment, the 7-series (Panther Point) chipsets are most closely associated with the Ivy Bridge series of CPUs. The coreboot codebase also doesn't really make a distinction between Sandy Bridge and Ivy Bridge, as they are essentially identical from a code point of view. Both of them are supported by code in `src/northbridge/intel/sandybridge` and `src/southbridge/intel/bx82x6x`. > Please dont do such a renaming. Its also unclear what scheme it would follow > in the future. Would then also all H61 boards get suddnely renamed to > 'ivybridge' because they support such CPU's? I hope not. > > If creating a group of the 70-series chipset is the goal, please name it x7x. > It would follow the scheme coreboot have for years with the x4x mainboard > series. > > Your example would then look like this: > > * asrock/x7x > * asrock/b75pro3-m > * asrock/h77pro4-m > > * asrock/x8x > * asrock/b85m_pro4 > * asrock/h81m-hds The xNx naming scheme also doesn't work in the general case. Because they share a codebase, it's theoretically possible that a 6-series and a 7-series board could be set up as variants with a common base board (it's even possible this has already been done with some boards). There's also chipsets that share an architecture (and thus share a codebase) but do not share the naming scheme, such as Q77 and C216 chipsets. Both of these are Panther Point chipsets but the x7x naming scheme does not capture this. There is even an existing case where boards with these chipsets were set up as variants: `src/mainboard/dell/snb_ivb_workstations` which supports the Optiplex 9010 (Q77 chipset) and Precision T1650 (C216 chipset). So really, without listing every compatible platform in the name, in general there is no succinct way of accurately expressing a particular grouping of platforms which share a codebase but may not share the exact same brandings (CPU family, chipset family, the codenames associated with them, etc) from Intel. So coreboot devs just choose a name that works well enough, otherwise we would need to resort to absurdly long names that accurately captures everything or duplicate code by forcing separate directories to be created for parts with incompatible names but otherwise compatible code. Yes, it makes things more confusing to navigate using the folder structure but I think that's already been accepted as a reality given the naming of the chipset directories and usage of the variant scheme for mainboards. ---------------------------------------- Refactoring #460: Make mainboards using the variant concept https://ticket.coreboot.org/issues/460#change-1413 * Author: Felix Singer * Status: New * Priority: Normal * Target version: none * Start date: 2023-02-14 ---------------------------------------- * asrock/ivybridge * asrock/b75pro3-m * asrock/h77pro4-m * asrock/haswell * asrock/b85m_pro4 * asrock/h81m-hds -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
