Issue #668 has been updated by Patrick Rudolph.
The Super I/O code should not use `console_serial_enabled()` at all. Quote "Whether the serial console should be used this stage.". It should use "CONFIG(CONSOLE_SERIAL) || CONFIG(CONSOLE_SERIAL_RUNTIME)" since the call to `nuvoton_enable_serial()` is missing in other stages. (Ideally this would be weak and called from console_init code, then `console_serial_enabled()` could be used). ---------------------------------------- Bug #668: mb/asus/p8x7x-series abuild broken https://ticket.coreboot.org/issues/668#change-2443 * Author: Keith Hui * Status: New * Priority: Normal * Assignee: Matt DeVillier * Category: coreboot common code * Target version: none * Start date: 2026-10-21 * Affected versions: main ---------------------------------------- abuild for this family of boards breaks if `CONFIG_BOOTBLOCK_CONSOLE` is disabled. The error is: ``` /usr/src/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: coreboot-builds/ASUS_P8Z77_V_LE_PLUS/bootblock/superio/nuvoton/common/early_serial.o: in function `nuvoton_enable_serial': /usr/src/coreboot/src/superio/nuvoton/common/early_serial.c:17:(.text.nuvoton_enable_serial+0xf): undefined reference to `console_serial_enabled' ``` It looks like a link time error, because console/serial_console.c is not being compiled into bootblock in this case. This unit is a new addition of commit 605cba2fd137 ("console: allow enabling serial console at runtime"). To reproduce, from root of coreboot source tree: 1. Create a text file `nobootconsole` with this content: ``` CONFIG_BOOTBLOCK_CONSOLE=n ``` 2. Run `util/abuild/abuild -p none -c 8 -t asus/p8x7x-series -S -K nobootconsole` This error isn't immediately obvious because CONFIG_BOOTBLOCK_CONSOLE defaults to enabled (for good reasons), but it is a user Kconfig option so none can guarantee it's always enabled. Whether CONFIG_SEPARATE_ROMSTAGE is chosen or not does not seem to matter. Build still fails. I should check with Matt before I start working around this by deferring nuvoton_enable_serial() to romstage at mainboard level, as my workaround plan can be tricky as I need to find a romstage hook before console init to make this call in. Ideally, if a board has serial console support and bootblock console is disabled, no serial and console init should happen in bootblock and should instead happen early in romstage. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
