Pádraig Brady wrote: > Removes 100 lines of tricky code. ... > Subject: [PATCH] maint: refactor to use read-file from gnulib > > * bootstrap.conf: Add the read-file module > * ptx.c: Replace the original code which would > needlessly read SIZE_MAX bytes of files larger than this. > * shuf.c: Replace the original code. > --- > bootstrap.conf | 1 + > src/ptx.c | 80 +++---------------------------------------------------- > src/shuf.c | 48 +++------------------------------ > 3 files changed, 11 insertions(+), 118 deletions(-)
Nice. It's not often we can remove so much code like that. I glanced through it (looks fine), applied it, built and ran a few smoke tests. Push at will ;-) Thanks!
