Pádraig Brady wrote: > On 08/02/11 10:14, Pádraig Brady wrote: >> On 08/02/11 08:42, Jim Meyering wrote: >>> Do you think it's worth resorting to the FS-name-based >>> test when python is not available? >> >> I don't think so, because df can currently allow the test to proceed >> erroneously: >> http://lists.gnu.org/archive/html/coreutils/2011-02/msg00018.html >> Also the overlap of fiemap capable systems with python should be good. > > Here's a further update to the fiemap checking in tests, > which will enable those tests on BTRFS. > I'm holding off on this however until we figure out > exactly what to do about the BTRFS vs EXT4 fiemap differences. ... > Subject: [PATCH] test: support more file systems in the cp fiemap tests > > * tests/cp/fiemap-perf: Check for fiemap support against a file > rather than a directory to enable tests on BTRFS for example. > Explicity disable the test on ext3 or file systems where we > can't determine the type. > * tests/cp/sparse-fiemap: Likewise. > * tests/init.cfg: Comment that BTRFS only supports fiemap > for regular files.
Looks good. Running tests where they are less likely to malfunction... Thanks!
