Pádraig Brady wrote: > On 24/02/11 10:05, Jim Meyering wrote: >> That looks fine, but I'd drop the use of -F, >> since it's just an optimization in this case, and >> probably not portable to some crufty targets. >> >> Hmm.. but I see uses of grep -F in other tests and >> even in bootstrap, so maybe it's not a problem, these days: >> >> $ git grep -l grep.-F >> bootstrap >> tests/cp/cp-mv-enotsup-xattr >> tests/cp/fiemap-perf >> tests/misc/xattr > > I did base the use on bootstrap and so decided it's OK. > This prompted me to look at the skipping in cp/sparse-fiemap > which didn't match the comment at least. Fixed with the attached. > > Subject: [PATCH] tests: without filefrag, only skip part of sparse-fiemap > > * tests/cp/sparse-fiemap: don't use skip_test_ which will > exit the test completely.
Good catch. Thanks!
