On 08/07/2012 05:01 PM, Ondrej Oprala wrote: > Hi, I've renamed the variable to be more hinting of it's purpose > and --no-preserve=mode should now work properly with directories > as well. > Cheers, > Ondrej
Thanks, that looks good ... maybe the directory case deserves to be added to the test. Minor nit: the change in copy_internal() is missing in the commit log. I'm sure that Padraig/Jim will add both when committing. BTW: Interestingly, the TODO entry mentioned "--no-preserve=X" to be buggy: > -cp --no-preserve=X should not attempt to preserve attribute X > - reported by Andreas Schwab but in fact, all the modes (t,o,l,c, and x) but "mode" have already been working. ;-) Have a nice day, Berny
