On 07/07/2014 05:40 PM, Pádraig Brady wrote: > On 07/07/2014 12:41 AM, Bernhard Voelker wrote: > Excellent review again.
Thanks! >> 12. man/coreutils.1: should avoid having the full path here: >> >>> Try: '/tmp/coreutils-8.22.142-d6383/src/coreutils PROGRAM_NAME --help' for >>> help on the particular program. >> >> I noticed the same in several man/*.1 files now. > > Separate issue: > > $ grep -l $PWD man/*.1 > man/basename.1 > man/cat.1 > man/chgrp.1 > man/chown.1 > man/comm.1 > man/coreutils.1 > man/dirname.1 > man/nohup.1 > man/numfmt.1 > man/rm.1 Au contraire, mon ami! That full path in the above man pages was introduced by _this_ patch. Besides the full path issue, "install" was replaced by "ginstall" in man1/install.1, and finally there is this change in test.1: -Report test translation bugs to <http://translationproject.org/team/> +Report [ translation bugs to <http://translationproject.org/team/> > One other change to consider is that we might > change `coreutils --coreutils-prog=` to `coreutils --program` > as the former is a bit long/awkward/redundant? What about --run --exec? Regarding the latest v9 patch: the symlinks mode doesn't work anymore: ./configure --quiet --prefix=/tmp/cu-symlinks --enable-single-binary=symlinks configure: error: program name transformations are not currently supported with --enable-single-binary=symlinks. Thanks & have a nice day, Berny
