On 03/05/18 13:05, Paul Eggert wrote: > -void _GL_ATTRIBUTE_PURE _GL_ATTRIBUTE_CONST > -chopt_free (struct Chown_option *); > +void chopt_free (struct Chown_option *);
That could break previous versions of gcc? Checking... yes :( src/chown-core.c:70:1: error: function might be candidate for attribute 'const' [-Werror=suggest-attribute=const] chopt_free (struct Chown_option *chopt _GL_UNUSED) ^~~~~~~~~~ This function is actually empty (so this sounds like a gcc8 bug). Anyway I pushed a solution that just defines away the empty function. thanks for the fixes, Pádraig.
