Hello,

I would like to get the opinion of this list on some tests paths changes.

Currently, many tests are located in the misc/ directory. For about 39 of the binaries, there are more than one test. I propose that for these binaries, we should move these tests into their own specific directories.

For example, tests/misc/tty-eof.pl and tests/misc/tty.sh into tests/tty/

This change would help us more easily identify which tests need to be run for each program.

I have already prepared the patches needed for this change. As an example, I've attached the first one in the stack.

Cheers,

Sylvestre
From 38b0133bb55dd7fc437326361730973a02e8b802 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru <sylves...@debian.org>
Date: Sun, 11 Jun 2023 11:55:56 +0200
Subject: [PATCH 01/39] tests: move the sort tests into a specific directory

---
 tests/local.mk                                | 46 +++++++++----------
 tests/{misc => sort}/sort-NaN-infloop.sh      |  0
 tests/{misc => sort}/sort-benchmark-random.sh |  0
 tests/{misc => sort}/sort-compress-hang.sh    |  0
 tests/{misc => sort}/sort-compress-proc.sh    |  0
 tests/{misc => sort}/sort-compress.sh         |  0
 tests/{misc => sort}/sort-continue.sh         |  0
 tests/{misc => sort}/sort-debug-keys.sh       |  0
 tests/{misc => sort}/sort-debug-warn.sh       |  0
 tests/{misc => sort}/sort-discrim.sh          |  0
 tests/{misc => sort}/sort-exit-early.sh       |  0
 tests/{misc => sort}/sort-files0-from.pl      |  0
 tests/{misc => sort}/sort-float.sh            |  0
 tests/{misc => sort}/sort-h-thousands-sep.sh  |  0
 tests/{misc => sort}/sort-merge-fdlimit.sh    |  0
 tests/{misc => sort}/sort-merge.pl            |  0
 tests/{misc => sort}/sort-month.sh            |  0
 tests/{misc => sort}/sort-rand.sh             |  0
 tests/{misc => sort}/sort-spinlock-abuse.sh   |  0
 tests/{misc => sort}/sort-stale-thread-mem.sh |  0
 tests/{misc => sort}/sort-u-FMR.sh            |  0
 tests/{misc => sort}/sort-unique-segv.sh      |  0
 tests/{misc => sort}/sort-unique.sh           |  0
 tests/{misc => sort}/sort-version.sh          |  0
 24 files changed, 23 insertions(+), 23 deletions(-)
 rename tests/{misc => sort}/sort-NaN-infloop.sh (100%)
 rename tests/{misc => sort}/sort-benchmark-random.sh (100%)
 rename tests/{misc => sort}/sort-compress-hang.sh (100%)
 rename tests/{misc => sort}/sort-compress-proc.sh (100%)
 rename tests/{misc => sort}/sort-compress.sh (100%)
 rename tests/{misc => sort}/sort-continue.sh (100%)
 rename tests/{misc => sort}/sort-debug-keys.sh (100%)
 rename tests/{misc => sort}/sort-debug-warn.sh (100%)
 rename tests/{misc => sort}/sort-discrim.sh (100%)
 rename tests/{misc => sort}/sort-exit-early.sh (100%)
 rename tests/{misc => sort}/sort-files0-from.pl (100%)
 rename tests/{misc => sort}/sort-float.sh (100%)
 rename tests/{misc => sort}/sort-h-thousands-sep.sh (100%)
 rename tests/{misc => sort}/sort-merge-fdlimit.sh (100%)
 rename tests/{misc => sort}/sort-merge.pl (100%)
 rename tests/{misc => sort}/sort-month.sh (100%)
 rename tests/{misc => sort}/sort-rand.sh (100%)
 rename tests/{misc => sort}/sort-spinlock-abuse.sh (100%)
 rename tests/{misc => sort}/sort-stale-thread-mem.sh (100%)
 rename tests/{misc => sort}/sort-u-FMR.sh (100%)
 rename tests/{misc => sort}/sort-unique-segv.sh (100%)
 rename tests/{misc => sort}/sort-unique.sh (100%)
 rename tests/{misc => sort}/sort-version.sh (100%)

diff --git a/tests/local.mk b/tests/local.mk
index 23a518a22..4bd0f62d1 100644
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -372,29 +372,29 @@ all_tests =					\
   tests/misc/sleep.sh				\
   tests/misc/sm3sum.pl				\
   tests/misc/sort.pl				\
-  tests/misc/sort-benchmark-random.sh		\
-  tests/misc/sort-compress.sh			\
-  tests/misc/sort-compress-hang.sh		\
-  tests/misc/sort-compress-proc.sh		\
-  tests/misc/sort-continue.sh			\
-  tests/misc/sort-debug-keys.sh			\
-  tests/misc/sort-debug-warn.sh			\
-  tests/misc/sort-discrim.sh			\
-  tests/misc/sort-files0-from.pl		\
-  tests/misc/sort-float.sh			\
-  tests/misc/sort-h-thousands-sep.sh		\
-  tests/misc/sort-merge.pl			\
-  tests/misc/sort-merge-fdlimit.sh		\
-  tests/misc/sort-month.sh			\
-  tests/misc/sort-exit-early.sh			\
-  tests/misc/sort-rand.sh			\
-  tests/misc/sort-spinlock-abuse.sh		\
-  tests/misc/sort-stale-thread-mem.sh		\
-  tests/misc/sort-unique.sh			\
-  tests/misc/sort-unique-segv.sh		\
-  tests/misc/sort-version.sh			\
-  tests/misc/sort-NaN-infloop.sh		\
-  tests/misc/sort-u-FMR.sh			\
+  tests/sort/sort-benchmark-random.sh		\
+  tests/sort/sort-compress.sh			\
+  tests/sort/sort-compress-hang.sh		\
+  tests/sort/sort-compress-proc.sh		\
+  tests/sort/sort-continue.sh			\
+  tests/sort/sort-debug-keys.sh			\
+  tests/sort/sort-debug-warn.sh			\
+  tests/sort/sort-discrim.sh			\
+  tests/sort/sort-files0-from.pl		\
+  tests/sort/sort-float.sh			\
+  tests/sort/sort-h-thousands-sep.sh		\
+  tests/sort/sort-merge.pl			\
+  tests/sort/sort-merge-fdlimit.sh		\
+  tests/sort/sort-month.sh			\
+  tests/sort/sort-exit-early.sh			\
+  tests/sort/sort-rand.sh			\
+  tests/sort/sort-spinlock-abuse.sh		\
+  tests/sort/sort-stale-thread-mem.sh		\
+  tests/sort/sort-unique.sh			\
+  tests/sort/sort-unique-segv.sh		\
+  tests/sort/sort-version.sh			\
+  tests/sort/sort-NaN-infloop.sh		\
+  tests/sort/sort-u-FMR.sh			\
   tests/split/filter.sh				\
   tests/split/suffix-auto-length.sh		\
   tests/split/suffix-length.sh			\
diff --git a/tests/misc/sort-NaN-infloop.sh b/tests/sort/sort-NaN-infloop.sh
similarity index 100%
rename from tests/misc/sort-NaN-infloop.sh
rename to tests/sort/sort-NaN-infloop.sh
diff --git a/tests/misc/sort-benchmark-random.sh b/tests/sort/sort-benchmark-random.sh
similarity index 100%
rename from tests/misc/sort-benchmark-random.sh
rename to tests/sort/sort-benchmark-random.sh
diff --git a/tests/misc/sort-compress-hang.sh b/tests/sort/sort-compress-hang.sh
similarity index 100%
rename from tests/misc/sort-compress-hang.sh
rename to tests/sort/sort-compress-hang.sh
diff --git a/tests/misc/sort-compress-proc.sh b/tests/sort/sort-compress-proc.sh
similarity index 100%
rename from tests/misc/sort-compress-proc.sh
rename to tests/sort/sort-compress-proc.sh
diff --git a/tests/misc/sort-compress.sh b/tests/sort/sort-compress.sh
similarity index 100%
rename from tests/misc/sort-compress.sh
rename to tests/sort/sort-compress.sh
diff --git a/tests/misc/sort-continue.sh b/tests/sort/sort-continue.sh
similarity index 100%
rename from tests/misc/sort-continue.sh
rename to tests/sort/sort-continue.sh
diff --git a/tests/misc/sort-debug-keys.sh b/tests/sort/sort-debug-keys.sh
similarity index 100%
rename from tests/misc/sort-debug-keys.sh
rename to tests/sort/sort-debug-keys.sh
diff --git a/tests/misc/sort-debug-warn.sh b/tests/sort/sort-debug-warn.sh
similarity index 100%
rename from tests/misc/sort-debug-warn.sh
rename to tests/sort/sort-debug-warn.sh
diff --git a/tests/misc/sort-discrim.sh b/tests/sort/sort-discrim.sh
similarity index 100%
rename from tests/misc/sort-discrim.sh
rename to tests/sort/sort-discrim.sh
diff --git a/tests/misc/sort-exit-early.sh b/tests/sort/sort-exit-early.sh
similarity index 100%
rename from tests/misc/sort-exit-early.sh
rename to tests/sort/sort-exit-early.sh
diff --git a/tests/misc/sort-files0-from.pl b/tests/sort/sort-files0-from.pl
similarity index 100%
rename from tests/misc/sort-files0-from.pl
rename to tests/sort/sort-files0-from.pl
diff --git a/tests/misc/sort-float.sh b/tests/sort/sort-float.sh
similarity index 100%
rename from tests/misc/sort-float.sh
rename to tests/sort/sort-float.sh
diff --git a/tests/misc/sort-h-thousands-sep.sh b/tests/sort/sort-h-thousands-sep.sh
similarity index 100%
rename from tests/misc/sort-h-thousands-sep.sh
rename to tests/sort/sort-h-thousands-sep.sh
diff --git a/tests/misc/sort-merge-fdlimit.sh b/tests/sort/sort-merge-fdlimit.sh
similarity index 100%
rename from tests/misc/sort-merge-fdlimit.sh
rename to tests/sort/sort-merge-fdlimit.sh
diff --git a/tests/misc/sort-merge.pl b/tests/sort/sort-merge.pl
similarity index 100%
rename from tests/misc/sort-merge.pl
rename to tests/sort/sort-merge.pl
diff --git a/tests/misc/sort-month.sh b/tests/sort/sort-month.sh
similarity index 100%
rename from tests/misc/sort-month.sh
rename to tests/sort/sort-month.sh
diff --git a/tests/misc/sort-rand.sh b/tests/sort/sort-rand.sh
similarity index 100%
rename from tests/misc/sort-rand.sh
rename to tests/sort/sort-rand.sh
diff --git a/tests/misc/sort-spinlock-abuse.sh b/tests/sort/sort-spinlock-abuse.sh
similarity index 100%
rename from tests/misc/sort-spinlock-abuse.sh
rename to tests/sort/sort-spinlock-abuse.sh
diff --git a/tests/misc/sort-stale-thread-mem.sh b/tests/sort/sort-stale-thread-mem.sh
similarity index 100%
rename from tests/misc/sort-stale-thread-mem.sh
rename to tests/sort/sort-stale-thread-mem.sh
diff --git a/tests/misc/sort-u-FMR.sh b/tests/sort/sort-u-FMR.sh
similarity index 100%
rename from tests/misc/sort-u-FMR.sh
rename to tests/sort/sort-u-FMR.sh
diff --git a/tests/misc/sort-unique-segv.sh b/tests/sort/sort-unique-segv.sh
similarity index 100%
rename from tests/misc/sort-unique-segv.sh
rename to tests/sort/sort-unique-segv.sh
diff --git a/tests/misc/sort-unique.sh b/tests/sort/sort-unique.sh
similarity index 100%
rename from tests/misc/sort-unique.sh
rename to tests/sort/sort-unique.sh
diff --git a/tests/misc/sort-version.sh b/tests/sort/sort-version.sh
similarity index 100%
rename from tests/misc/sort-version.sh
rename to tests/sort/sort-version.sh
-- 
2.39.2

Reply via email to