On 9/24/25 4:23 AM, Collin Funk wrote:
The attached patch replaces uses of ARRAY_CARDINALITY with countof which
is expected to be standardized and provided by Gnulib.

One thing: sc_prohibit_argmatch_without_use

Patch attached.

Have a nice day,
Berny
From 3276693bebae63f1b8aa2a891afc8db6c9944b99 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <[email protected]>
Date: Thu, 25 Sep 2025 22:50:01 +0200
Subject: [PATCH] join: remove unused #include "argmatch.h"

Prompted by the syntax-check failure:
  maint.mk: the above files include argmatch.h but don't use it
  make: *** [maint.mk:741: sc_prohibit_argmatch_without_use] Error 1

* src/join.c: Remove include, as the previous commit changed from using
ARRAY_CARDINALITY to countof - for which system.h includes the header.
---
 src/join.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/join.c b/src/join.c
index 5cf87d1e8..e1899a93a 100644
--- a/src/join.c
+++ b/src/join.c
@@ -33,7 +33,6 @@
 #include "stdio--.h"
 #include "xmemcoll.h"
 #include "xstrtol.h"
-#include "argmatch.h"
 
 /* The official name of this program (e.g., no 'g' prefix).  */
 #define PROGRAM_NAME "join"
-- 
2.51.0

Reply via email to