Looking at how "argmatch.h" is included in various files, we see that src/wc.c is an outlier using <...> syntax instead of "...":
$ GIT_PAGER= git grep 'include .argmatch.h' | column -t src/cp.c:#include "argmatch.h" src/date.c:#include "argmatch.h" src/digest.c:#include "argmatch.h" src/du.c:#include "argmatch.h" src/join.c:#include "argmatch.h" src/ls.c:#include "argmatch.h" src/mv.c:#include "argmatch.h" src/numfmt.c:#include "argmatch.h" src/od.c:#include "argmatch.h" src/ptx.c:#include "argmatch.h" src/rm.c:#include "argmatch.h" src/shred.c:#include "argmatch.h" src/sort.c:#include "argmatch.h" src/stat.c:#include "argmatch.h" src/tail.c:#include "argmatch.h" src/tee.c:#include "argmatch.h" src/touch.c:#include "argmatch.h" src/uniq.c:#include "argmatch.h" src/wc.c:#include <argmatch.h> Paul changed this explicitly for src/wc.c in commit 8d41285fe494613 (2023): * src/wc.c: Use "#include <...>" for files not in the current dir. Well, gnulib recommends "..." $ grep -iA1 include gnulib/modules/argmatch Include: "argmatch.h" Technically it doesn't seem to matter [1], because we're using -I which <...> also searches. Still there might be a case where the search order might be messed and the compiler would find the system library before the replacement one from gnulib, no? [1] https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html Yet I'm not sure what they mean by "quote directories": It searches [...] first in the directory containing the current file, then in the quote directories and then [...] ______________^^^^^^^^^^^^^^^^^ So is this only a matter of consistency, or do we have a potential issue? Have a nice day, Berny
