On 30/09/2025 03:42, Collin Funk wrote:
Pádraig Brady <[email protected]> writes:
I'd change the license to the same as mcel (LGPLv2+)
in case it's ever moved to gnulib.
Yep, I didn't run 'make syntax-check'. This patch was more of a RFC
and
I was expecting it needed to be cleaned up.
I'm fine with making the mbbuf module LVPLv2+, but that would mean
we
cannot use ioblksize.h since it is GPLv3+. We would have to re-license
that or use some other constant like BUFSIZ. What do you think?
Ideally then we'd move ioblksize module to gl/, and re-license as LGPLv2+I
originated it in https://github.com/coreutils/coreutils/commit/55efc5f3e
so am happy to re-license.
Great.
I changed it a bit to use an mbbuf_t type which expects a buffer
allocated by the caller instead of a global variable. This should make
it useful in more situations, e.g. if a program wants to malloc a buffer
for each thread.
This also removes the need to include ioblksize.h there. We can still
move it to gl/ later and re-license though if you like.
v2 passes syntax-checks too, with some exclusions for preprocessor
indentation and licensing, as discussed previously.
Cool. That's more library like and I agree it's
best to decouple ioblksize anyway.
LGTM.
thanks!
Padraig
