Sylvestre Ledru <[email protected]> writes: > Hello > > Adding a case that wasn't covered in the install testsuite! > > Thanks > Sylvestre > > From d6d9927ad760c55b55056c89b2a97f274087dd57 Mon Sep 17 00:00:00 2001 > From: Sylvestre Ledru <[email protected]> > Date: Sat, 15 Nov 2025 22:24:04 +0100 > Subject: [PATCH] tests: install should ignore umask > > Identified here: > <https://github.com/uutils/coreutils/pull/9254> > > * tests/install/basic-1.sh: Add the check. > --- > tests/install/basic-1.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tests/install/basic-1.sh b/tests/install/basic-1.sh > index b529f2af9..824a9ce91 100755 > --- a/tests/install/basic-1.sh > +++ b/tests/install/basic-1.sh > @@ -160,4 +160,12 @@ if ! mkdir sub-ro/d; then > grep 'cannot create directory' err || { cat err; fail=1; } > fi > > +# Test install with --mode=+w (relative mode) > +umask 0022 || framework_failure_ > +touch file1 || framework_failure_ > +ginstall file1 file2 --mode=+w || fail=1 > +# Check that file2 has permissions --w--w--w- > +mode=$(ls -l file2|cut -b-10) > +test "$mode" = --w--w--w- || fail=1 > + > Exit $fail
Thanks! I think this test should go in a seperate file with "working_umask_or_skip_" called at the start. Pádraig, WDYT? Collin
