Hi Michael,

This patch has two problems:

1) It very much looks like it has not been tested.
   If you submit a patch, by default, we assume that we can trust it because
   you have tested it. You can, alternatively, submit an untested patch,
   but then _say_so_, that it is untested.

2) The patch confuses two functionalities:
     - (a) whether to interface with libselinux,
     - (b) whether to build the chcon, runcon programs.
   By the GNU Coding Standards [1], (a) should be triggered by a --with-*
   configure option; whereas (b) should be triggered by a --enable-*
   configure option.

   So, instead of changing the meaning of the --with-selinux /
   --without-selinux options, what we would need is a patch that
   enables the build of the chcon, runcon programs conditionally based
   on some --enable-* option.

Bruno

[1] https://www.gnu.org/prep/standards/html_node/Configuration.html




Reply via email to