Pádraig Brady <[email protected]> writes: > On 29/04/2026 10:45, Pádraig Brady wrote: >> On 29/04/2026 06:51, Bruno Haible via GNU coreutils General Discussion wrote: >>> In yesterday's CI run, I see a compilation error on Alpine Linux and on >>> OpenBSD. >>> >>> On Alpine Linux: >>> >>> gcc -I. -I.. -I./lib -Ilib -I../lib -Isrc -I../src -Wall >>> -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare >>> -Wno-undef -Wno-unused-function -Wno-unused-parameter >>> -Wno-float-conversion -Wimplicit-fallthrough -Wno-pedantic >>> -Wno-sign-conversion -Wno-type-limits -Wno-unused-const-variable >>> -Wno-unsuffixed-float-constants -Wno-error -g -O2 -MT >>> lib/libcoreutils_a-mbbuf.o -MD -MP -MF >>> lib/.deps/libcoreutils_a-mbbuf.Tpo -c -o lib/libcoreutils_a-mbbuf.o >>> `test -f 'lib/mbbuf.c' || echo '../'`lib/mbbuf.c >>> In file included from ../lib/mbbuf.c:22: >>> ../lib/mbbuf.h:41:19: error: 'UINT32_MAX' undeclared here (not in a >>> function) >>> 41 | #define MBBUF_EOF UINT32_MAX >> Collin, >> Rather than depending on stdint-h and including stdint.h >> I wonder could we define MBBUF_EOF in terms of mcel constants. >> Maybe MCEL_CHAR_MAX+1 or (MCEL_ERR_MIN << MCEL_ERR_SHIFT) ? > I pushed #define MBBUF_EOF (MCEL_CHAR_MAX+1)
Sorry, I saw your message before work but forgot to respond after. That change sounds good to me. Collin
