On 23/08/2026 23:43, Collin Funk wrote:
I noticed this one by chance viewing the source code. I'm not too sure
if a test can be added for it.
Given a large enough input file, and a target that is the same, e.g.,
by using 'cp -a', the file size checks via stat(3) should pass. Then,
as the contents are being compared if you append bytes to the
destination, the EOF on the destination is not checked. So
"have_same_content" will return the contents are the same if the
entire source contents are a prefix of those in the destination.
With large files you should be able to reproduce it reliability, but
obviously I would like to avoid that in the test suite.
Is this gaining you anything though.
Just because the file extended in the narrow window while install(1)
was comparing doesn't really matter.
If it extends just after that we also miss it.
So I don't think it's worth complicating the code for that.
cheers,
Padraig
