Pádraig Brady <[email protected]> writes:

> +#include <uchar.h>
> +#include <wchar.h>
> +#include <stdint.h>

Is the wchar.h include needed for some reason? I though uchar.h should
cover anything, unless we need functions that operate on wchar_t like in
src/printf.c, but that doesn't seem to be the case here.

Other than that tiny point, these looks good. Nice work! Using a 'wc'
version built from some commit before 9.12 was released, and with your
changes:

$ perf stat --repeat 1000 wc -m /usr/share/dict/words  > /dev/null
[...]
       0.011925750 +- 0.000011327 seconds time elapsed  ( +-  0.09% )
$ perf stat --repeat 1000 ./src/wc -m /usr/share/dict/words > /dev/null
[...]
       0.001552144 +- 0.000005435 seconds time elapsed  ( +-  0.35% )

Collin

Reply via email to