Hi Eric,

Thanks for your review.

In the interest of speedy response and to simplify the continued IESG review, I 
have prioritised your DISCUSS in this mail. Please see comments inline inside 
brackets: <<GS: … >>.

We have processed most of your other comments as well but not completed all PRs 
yet.

Thanks,
Göran

From: Éric Vyncke via Datatracker <[email protected]>
Date: Friday, 10 April 2026 at 16:05
To: The IESG <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; 
[email protected] 
<[email protected]>; [email protected] 
<[email protected]>; [email protected] <[email protected]>
Subject: Éric Vyncke's Discuss on draft-ietf-cose-cbor-encoded-cert-17: (with 
DISCUSS and COMMENT)

Éric Vyncke has entered the following ballot position for
draft-ietf-cose-cbor-encoded-cert-17: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to 
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fabout%2Fgroups%2Fiesg%2Fstatements%2Fhandling-ballot-positions%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cc7c67faeda67436a583d08de970a246e%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639114267005385911%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=JhQVTLoJ6NFuY2kJkxuBLvbMYg%2FNz0DF5emZrLeD0%2FE%3D&reserved=0<https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/>
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-cose-cbor-encoded-cert%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cc7c67faeda67436a583d08de970a246e%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639114267005413176%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=7nUinYp7QhqqG%2FeY3UtcsxJ%2FePHD77%2BRoxXpN3V1%2BNY%3D&reserved=0<https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/>



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------


# Éric Vyncke INT AD comments for draft-ietf-cose-cbor-encoded-cert-17
CC @evyncke

Thank you for the work put into this document.

Please find below some blocking DISCUSS points, some non-blocking COMMENT
points/nits (replies would be appreciated even if only for my own education).

Special thanks to Ivaylo Petrov for the shepherd's write-up including the WG
consensus *BUT* it lacks the justification of the intended status.

Other thanks to Ted Lemon, the DNS directorate reviewer:
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Freview-ietf-cose-cbor-encoded-cert-17-dnsdir-telechat-lemon-2026-03-30%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cc7c67faeda67436a583d08de970a246e%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639114267005429930%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=EHZ7cxaNWA9%2FULcsCQgXE4S1TEU0fZUJp94OPjuz6hg%3D&reserved=0<https://datatracker.ietf.org/doc/review-ietf-cose-cbor-encoded-cert-17-dnsdir-telechat-lemon-2026-03-30/>
(and I have read the previous email threads with the authors)

I hope that this review helps to improve the document,

Regards,

-éric

Note: this ballot comments follow the Markdown syntax of
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmnot%2Fietf-comments%2Ftree%2Fmain&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cc7c67faeda67436a583d08de970a246e%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639114267005445584%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=UCfaY0shPKsvojn4bVVDgkuSMUxeBY1seUlEpgqrhug%3D&reserved=0<https://github.com/mnot/ietf-comments/tree/main>,
 i.e., they can be processed by
a tool to create github issues.

## DISCUSS (blocking)

As noted in
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fstatement-iesg-handling-ballot-positions-20220121%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cc7c67faeda67436a583d08de970a246e%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639114267005461658%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=9LHueDVqOlDKqlmMJpXoRpDMg87o%2Fwot5Fkj5Kj9QuU%3D&reserved=0<https://datatracker.ietf.org/doc/statement-iesg-handling-ballot-positions-20220121/>,
a DISCUSS ballot is a request to have a discussion on the points below; I
really think that the document would be improved with a change here, but can be
convinced otherwise.

### Section 3.3

About "IpAddrBlocks", the whole text is a little unclear to me to be honest, so
I may have misread the specification BUT the text `It should be noted that
using address differences for compactness prevents encoding an address range
larger than 2**64 - 1 corresponding to the CBOR integer max value.` seems
really a bad choice for IPv6 addresses as the usual prefix size if 64-bit long.
I.e., the encoding cannot cope with 2001:db8::/63. There are no examples in the
appendix about this encoding, and this does not help the reader.

<<GS: Thanks, we have updated the encoding, re-written the text and included an 
example with IPv4 and IPv6, please see PR#340:
https://github.com/cose-wg/CBOR-certificates/pull/340/changes
>>

Also very unclear to me (missing references and how to use): `IPAddressFamily =
(AFI: uint, SAFI: uint / null, IPAddressChoice)`

<<GS:  Text and references on this are also added included an example in PR#340:
https://github.com/cose-wg/CBOR-certificates/pull/340/changes
>>


The text `as specified in [I-D.ietf-lamps-macaddress-on]` makes the reference
normative.

<<GS: Thanks, fixed in PR#355:
https://github.com/cose-wg/CBOR-certificates/pull/355/changes
>>



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


## COMMENTS (non-blocking)

### Section 1

Please add a reference to `IEEE 802.1AR (DevID)`.
<<GS: Fixed in Med's PR#347:
https://github.com/cose-wg/CBOR-certificates/pull/347/changes
>>


Also add references to `C509 is deployed in, e.g.,…`
`

<<GS:  We rephrased this in PR#354 since there are not much public references:
https://github.com/cose-wg/CBOR-certificates/pull/354/changes

>>


### Section 3.1.8 (and others)

What does `Not supported.` mean in this case ? Should the text be explicit and
state that if this field exist in the X.509 then no C509 can be generated?
(just to be clear)

<<GS: Thanks, more generally explained in PR#355:
https://github.com/cose-wg/CBOR-certificates/pull/355/changes
>>


### Section 3.3

About "Name Constraints" s/where the last octet indicates the number of bits in
the *netmask*/where the last octet indicates the number of bits in the *prefix*/

<<GS: Thanks, fixed in PR#355:
https://github.com/cose-wg/CBOR-certificates/pull/355/changes
>>

About "IPAddrBlocks", just wondering why not using the 'number of used octets'
as it is closer to the usual CIDR/IPv6 prefix notation in `Each AddressPrefix
is encoded as a CBOR bytes string (without the unused bits octet) followed by
the number of unused bits encoded as a CBOR uint` ?

<<GS: Allow us to get back on this.>>


`KeyIdentifier SHOULD be composed of the leftmost 160-bits of the SHA-256 hash
of the CBOR encoded subjectPublicKey. Other methods of generating unique
numbers can be used.` why a SHOULD as other methods can be used ? This sentence
does not seem to follow [[ BCP ]]

<<GS: This was discussed in the WG. RFC 5280 provides as one option a 160-bit 
hash, but this is just an example. Rephrased in PR#355:
https://github.com/cose-wg/CBOR-certificates/pull/355/changes
>>



### Section 9

Suggest adding informative reference to the newly created IANA registries *AND*
updated existing registries.

<<GS: Thanks, will do this, but no PR at the moment.>>


Somehow like Med Boucadair, I am puzzled by the last paragraph as it is
confusing at the best while trying to paraphrase RFC 8126. Let's rather delete
it.

<<GS: Please see response to Med’s review.
https://www.mail-archive.com/[email protected]/msg05330.html
Since this text is a result of a previous IESG discussion we hope any new 
directions from IESG will explain when and when not to use it.>>


### Section A.3.1

Please avoid using real FQDN (e.g., `sni.cloudflaressl.com`) in IETF documents,
rather use "example.org"

<<GS: There is a trade-off between using real certificates and mock-up. In the 
draft we tend to use real certificates to make good illustrations of how the 
encoding works in practice. After all, the purpose of this document is to 
specify general re-encoding of X509 certificates. Moreover, since we have not 
generated these certificates, if we would replace all FQDNs then we need to 
calculate new signatures in order to make the certificates verify, which is a 
substantial work effort also considering certificate chains. We propose to keep 
the real FQDNs.>>

_______________________________________________
COSE mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to