Hi Roman,

Thanks for your review, see responses inline below.

We have tried to address the DISCUSS part in PR#379
https://github.com/cose-wg/CBOR-certificates/pull/379

For overview we merged this PR into the Editor’s copy:
https://cose-wg.github.io/CBOR-certificates/draft-ietf-cose-cbor-encoded-cert.html

Thanks,
Göran

From: Roman Danyliw via Datatracker <[email protected]>
Date: Wednesday, 29 April 2026 at 17:54
To: The IESG <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; 
[email protected] 
<[email protected]>; [email protected] 
<[email protected]>
Subject: Roman Danyliw's Discuss on draft-ietf-cose-cbor-encoded-cert-18: (with 
DISCUSS and COMMENT)

Roman Danyliw has entered the following ballot position for
draft-ietf-cose-cbor-encoded-cert-18: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to 
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fabout%2Fgroups%2Fiesg%2Fstatements%2Fhandling-ballot-positions%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cf89b1e2c09b743402c1008dea6078660%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639130748411251450%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=MkuEq8mY%2BgV2rqLygsxZFX7kLJKtCHZkUuBp%2FOTWD3M%3D&reserved=0<https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/>
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-cose-cbor-encoded-cert%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cf89b1e2c09b743402c1008dea6078660%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639130748411297392%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=7BK%2FdN%2BJCXncZIFPWey1vQKTfLv3vYDKRUuPBFNOIWc%3D&reserved=0<https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/>



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

** Section 8.4
   The
   fields of the registry are Value, Comments, and subjectPrivateKey,
   and Reference, where Value is an integer, and the other columns are
   text strings.

The value of subjectPrivateKey seems to be underspecified.  Yes, it is text
string.  However, what are the valid values?  What does this field describe?

[GS: More details added and a section referenced.]


** Section 8.6, 8.7
   The fields Name, OID, and DER are mandatory.
…
   If
   OID is present, the OID is given in dotted decimal representation,
   and the DER column contains the hex string of the DER-encoded OID
   [X.690].

-- Per sentence one, the OID field is mandatory.  Per sentence two, there
appears to be conditionality to whether the OID might be present.  Which is it?

[GS: It is mandatory but may be N/A, clarification added.]

-- Where are the OID and DER fields defined?

[GS: The  OID is defined in the reference and the DER is derived from the OID 
according to DER encoding rules.]

** Section 8.8.
Where are OID, DER, and AttributeValue defined?

[GS: The  OID is defined in the reference and the DER is derived from the OID 
according to DER encoding rules.  "AttributeValue” is a typo, should be 
“ExtensionValue", fixed in the Editor’s copy]

** Section 8.9.
Where are the OID and DER fields defined?

[GS: The  OID is defined in the reference and the DER is derived from the OID 
according to DER encoding rules.]

** Section 8.9, 8.10
   The fields Name, OID, and DER are mandatory.

Is it desirable to register a field with no comment (reference)?

[GS: We clarified in these and other IANA sections the use of references in the 
Comment field.]

** Section 8.11.  8.12.
Where are the OID and DER fields defined?

[GS: The  OID is defined in the reference and the DER is derived from the OID 
according to DER encoding rules.]

Is it desirable to register a code point with no comment (reference)?

[GS: We clarified in these and other IANA sections the use of references in the 
Comment field.]

** Section 8.13.
Where are the OID and DER fields defined?

[GS: The  OID is defined in the reference and the DER is derived from the OID 
according to DER encoding rules.]

Is it desirable toregister a code point with no comment (reference)?

[GS: We clarified in this and other IANA sections the use of references in the 
Comment field.]

** Section 8.14 and 8.15.  Do not use BCP14 keywords in IANA considerations.
See
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fstatement-iesg-statement-on-clarifying-the-use-of-bcp-14-key-words%2F&data=05%7C02%7Cgoran.selander%40ericsson.com%7Cf89b1e2c09b743402c1008dea6078660%7C92e84cebfbfd47abbe52080c6b87953f%7C0%7C0%7C639130748411317308%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Yj31PJRbl3ydqysUlH20h0sLNeoEc0zSotLBk%2FLA%2Fgk%3D&reserved=0<https://datatracker.ietf.org/doc/statement-iesg-statement-on-clarifying-the-use-of-bcp-14-key-words/>.

[GS: Changed to lower case.]

** Section 8.14.  What does the comment field text that says “Don’t use” mean.
Where is it explained that the comment field has recommendations on usage?

[GS: Removed from IANA section and replaced by a new paragraph in the Security 
Considerations.]

Thanks
Göran

----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you to Russ Housley for the GENART review.

** Section 1.  Editorial.

   Implementors can get familiar
   with CBOR by using the CBOR playground [CborMe].

It is not clear what the value of this text for an archival document.

[GS: The CBOR playground, https://cbor.me/,  is a tool for testing CBOR 
encoding which is valuable for developers, for example during debugging. At 
some point, people did not know this existed and we were asked why they were 
not informed about it. As for it archival value, we could add “at the time of 
publishing” or similar to make the sentence more time-dependent.]


** Section 8.15.1.  What does this section have to do with IANA actions?

[GS: Good point. I propose to revise/remove this in a another PR.]

Thanks
Göran

_______________________________________________
COSE mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to