Great, thanks a lot Hannes. -M

On Sat, Nov 14, 2026 at 1:41 AM Hannes Tschofenig <[email protected]>
wrote:

> Hi Mallory,
>
> thanks for your review.
>
> The structure of the document is indeed different than the structure of
> the HPKE specification. This was done on purpose because the HPKE
> specification focuses on the algorithm description while this document
> is about conveying the output of the HPKE algorithm in COSE. I have,
> however, added text to the early part of the document to explain the
> structure of the document to the reader.
>
> I created a table in the IANA consideration and it indeed looks nice.
>
> Regarding the term "test vector" vs. "testvector" I looked at other
> documents in the COSE group and they use two words. So, I will do that
> as well.
>
> I left the examples in the body of the document since those examples
> tend to help the reader understand the adjacent text. The test vectors
> are in the appendix since most readers do not care much about them.
>
> I have created a PR at
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cose-2Dwg_draft-2Dietf-2Dcose-2Dhpke_pull_157_changes&d=DwIFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=krANNudPSfUTEf2kXiduBUqRjXhDsKNCASr1kibHLfs&m=wLWkM5bizsKLLV85Z1as_gsDJhfywHbqNpunFGznvVEco-KkI8neXJezfUHDUKWv&s=UNpey_eJR20HIiwcabPHCqwhaXwYNo10OfQA5iss-0I&e=
> to
> address your feedback.
>
> Ciao
> Hannes
>
>
> Am 26.10.2026 um 16:04 schrieb Mallory Knodel via Datatracker:
> > Document: draft-ietf-cose-hpke
> > Title: Use of Hybrid Public-Key Encryption (HPKE) with CBOR Object
> Signing and Encryption (COSE)
> > Reviewer: Mallory Knodel
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed
> > by the IESG for the IETF Chair. Please treat these comments just
> > like any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.ietf.org_en_group_gen_GenArtFAQ&d=DwIFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=krANNudPSfUTEf2kXiduBUqRjXhDsKNCASr1kibHLfs&m=wLWkM5bizsKLLV85Z1as_gsDJhfywHbqNpunFGznvVEco-KkI8neXJezfUHDUKWv&s=N-T2kZZcCzGEFeC7Cpokr32iHtdNMCl4v7-FUeN1FDk&e=
> >.
> >
> > Document: draft-ietf-cose-hpke-??
> > Reviewer: Mallory Knodel
> > Review Date: 2026-10-26
> > IETF LC End Date: 2026-10-22
> > IESG Telechat date: Not scheduled for a telechat
> >
> > Summary: The document defines the use of HPKE with COSE. Checking in
> > on other reviews and also reviews of ietf-hpke-hpke there are some
> > open, consequential issues that aren't yet addressed, so perhaps
> > timing and content of this draft is dependent on that one. Therefore,
> > I've intentionally kept my feedback very surface level and focussed
> > on readability.
> >
> > Major issues: None
> >
> > Minor issues: None
> >
> > Nits/editorial comments:
> >
> > * It seems to me that the IANA section might be better as a table
> >    instead of a long, linear outline.
> >
> > * Might Section 5 Examples be an appendix, before Testvectors [sic]?
> >
> > * "Test Vectors" seems to be two words in other documents.
> >
> > * I expected this document to follow more or less the outline of
> >    RFC9180. It's okay that it doesn't, but perhaps a paragraph at
> >    the end of the introduction will better help the reader understand
> >    the structure and flow of the document (and why various choices
> >    were made). Furthermore in each of the sections 3, 4 and 5 it
> >    might be helpful to briefly explain why subsections appear in
> >    the order that they do. In general I found that I had to
> >    essentially read the entire document to understand why it is
> >    organized the way that it is, and I'm still somewhat left with
> >    questions. You could, say, extend 3.1 with some additional
> >    architectural context explaining why both modes are specified,
> >    how they relate to existing mechanisms, and what security
> >    properties or tradeoffs implementers should consider, eg move
> >    up the "security design rationale" into the overview.
> >
> >
> > _______________________________________________
> > COSE mailing list -- [email protected]
> > To unsubscribe send an email to [email protected]
>
_______________________________________________
COSE mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to