On Oct 7, 2013, at 11:33 PM, Andrew Mortensen <and...@weblogin.org> wrote:
> On Oct 7, 2013, at 10:54 AM, James Yerge <jye...@tenable.com> wrote:
>
>> I've searched around the net and wasn't able to find much information on
>> this topic other than the module will compile under Apache 2.4.X. Given that
>> that's the case, reviewing the module source code indicates that the API
>> calls need to be updated. I've compiled the module and have tested under
>> Apache 2.4.X without any code modifications to the module's source and in
>> turn, Cosgin functionality wasn't usable. Reviewing the logs indicated that
>> malformed headers were being sent.
>>
>> Are there any plans to update the module source to work with Apache 2.4.X or
>> a patch. Or, maybe I'm doing something wrong when compiling – has anyone
>> tested under Apache 2.4.X successfully?
>
> Thanks for the report. I did some early testing with 2.4.x and things were
> OK. Let me bring up the VM and test with the current release, and I'll get
> back to you.
Aside from referring to a member of a data structure that's not available in
2.4--the connection's remote_ip is now client_ip--everything seems to be
working fine so far. I'll continue testing.
In the meantime, here's a patch against git head for the apache2 module to
correct the problem.
andrew
--
diff --git a/filters/apache2/mod_cosign.c b/filters/apache2/mod_cosign.c
index 2d4e95d..5a919ef 100755
--- a/filters/apache2/mod_cosign.c
+++ b/filters/apache2/mod_cosign.c
@@ -340,7 +340,7 @@ cosign_handler( request_rec *r )
}
cv = cosign_cookie_valid( cfg, cookie, &rekey, &si,
- r->connection->remote_ip, r->server );
+ r->connection->client_ip, r->server );
if ( rekey != NULL ) {
/* we got a rekeyed cookie. let the request pool free it later. */
apr_pool_cleanup_register( r->pool, (void *)rekey, (void *)free,
@@ -528,7 +528,7 @@ cosign_auth( request_rec *r )
* Otherwise, retrieve the auth info from the server.
*/
cv = cosign_cookie_valid( cfg, my_cookie, NULL, &si,
- r->connection->remote_ip, r->server );
+ r->connection->client_ip, r->server );
if ( cv == COSIGN_ERROR ) {
return( HTTP_SERVICE_UNAVAILABLE ); /* it's all forbidden! */
}
>
> andrew
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk_______________________________________________
> Cosign-discuss mailing list
> Cosign-discuss@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/cosign-discuss
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________ Cosign-discuss mailing list Cosign-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cosign-discuss
