On Wed, May 15, 2002 at 06:22:09PM +0200, Andreas Marcel Riechert wrote: > Autrijus, > Probably Bundle's are the next candidate were the automatic tests > are not necessarily appropriate.
Indeed; patched as below. Note that all it does is refusing to send out
UNKNOWN reports for bundles; the test process still goes through normally.
This is because
1) There could be people who include Bundles in a distribution
2) And maybe also provide tests for them.
Once the magicquoting issue is resolved, if cpanplus 0.04 is not yet ready,
I'll talk with Jos to perhaps release a 0.034 for test-related patchs so far.
Also included in the patch is a chunk that deals with -binMac probing.
Thanks. :)
/Autrijus/
==== //depot/devel/lib/CPANPLUS/Internals/Report.pm#6 -
/tmp/cpanplus/devel/lib/CPANPLUS/Internals/Report.pm ====
@@ -36,8 +36,10 @@
HPUX => 'hpux',
Linux => 'linux',
MSDOS => 'dos',
+ 'bin\\d*Mac'=> 'MacOS', # binMac, bin56Mac, bin58Mac...
Mac => 'MacOS',
MacPerl => 'MacOS',
+ MacOS => 'MacOS',
MacOSX => 'darwin',
MPEiX => 'mpeix',
OS2 => 'os2',
@@ -68,7 +70,7 @@
if ($self->{_todo}{failed}{$name} or $failed) {
foreach my $platform (keys %OS) {
- if ($name =~ /^$platform\b/i) {
+ if ($name =~ /\b$platform\b/i) {
# a platform-specific module
$grade = 'na' unless ($^O =~ /^(?:$OS{$platform})$/);
last;
@@ -153,11 +155,16 @@
push @inform, "$module->{author}\@cpan.org";
}
elsif ($grade eq 'unknown') {
+ if ($name =~ /\bBundle\b/) {
+ print "UNKNOWN grades for Bundles are normal; skipped.\n";
+ return;
+ }
+
return unless $self->_can_use( modules => { 'File::Temp' => '0.0' } );
+
($fh, $filename) = File::Temp::tempfile( UNLINK => 1 );
- my $stage = lc($self->{_error}->stack);
- $stage = 'make test';
+ my $stage = 'make test';
print $fh '' . << ".";
This is an error report generated automatically by CPANPLUS.
msg35077/pgp00000.pgp
Description: PGP signature
