-----Original Message----- > > On Mon, Jul 19, 2021 at 12:29 PM HAGIO KAZUHITO(萩尾 一仁) <[email protected] > <mailto:[email protected]> > > wrote: > > > -----Original Message----- > > > > I don't know may be some parts of bitmap weren't flushed either. > I'll > > > > investigate that further why "valid_pages * descriptor size" is > not > > > > equal to offset from data_offset to zero page on an incomplete > dump. > > > > > > ugh, sorry, bitmap also can be incomplete in cyclic mode. In that > case, > > > page_is_dumpable() cannot be used to estimate the size in the first > place, > > > maybe all we can do is to get total_valid_pages.. > > > > > > > Hi Kazu, > > > > Thanks for clarifying this. I think two-pass approach might still > work with > > this. > > > > I have an incomplete dump where data_offset = 8130000, > zero_page_offset = 93d5c90 > > and total_valid_pages = 476223. > > > > pd_count = (zero_page_offset - data_offset) / 24 (pd size) = 814726. > > > > So, we know that 338503 pages are missed in the bitmap and the dump is > > 338503 pages smaller than it could be (at most, if every missed page > > takes full page). > > That sounds good. > > > > > Either way, it seems you're fine with the first four patches: > > > https://listman.redhat.com/archives/crash-utility/2021-June/msg00078.html > > > > Do we want to merge them? (v3 of the series only updates the last > patch) > > Ok, for the v2 series except for the 5/5 patch, > Acked-by: Kazuhito Hagio <[email protected] > <mailto:[email protected]> > > > Thanks, > Kazu > > > Also looks good to me, for the v2(first four patches): > Acked-by: Lianbo Jiang <[email protected] <mailto:[email protected]> >
Applied. https://github.com/crash-utility/crash/compare/80334ed...881f33d Thanks, Kazu -- Crash-utility mailing list [email protected] https://listman.redhat.com/mailman/listinfo/crash-utility
