symname_hash_install won't check if spn has been installed before. If
it does, the second install will corrupt the hash table as well as
spn->cnt counting. It should never happen in normal cases, but we need
get notified if it happens.

Signed-off-by: Tao Liu <[email protected]>
---
 symbols.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/symbols.c b/symbols.c
index f8b4998..a453a6a 100644
--- a/symbols.c
+++ b/symbols.c
@@ -1167,6 +1167,7 @@ symname_hash_install(struct syment *table[], struct 
syment *spn)
                spn->name_hash_next = NULL;
        } else {
                while (sp) {
+                       assert(sp != spn);
                        if (STREQ(sp->name, spn->name)) {
                                sp->cnt++;
                                spn->cnt++;
-- 
2.29.2

--
Crash-utility mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/crash-utility

Reply via email to