On Mon, Feb 14, 2022 at 9:55 AM HAGIO KAZUHITO(萩尾 一仁) <[email protected]>
wrote:

> -----Original Message-----
> > We can get VA_BITS_ACTUAL from CONFIG_ARM64_VA_BITS by guess.
> >
> > Without this patch, we may need to use "--machdep vabits_actual=48" to
> > set the VA_BITS_ACTUAL.
> >
> > Signed-off-by: Huang Shijie <[email protected]>
> > ---
> > v1 --> v2:
> >       Remove the DISKDUMP limit.
>
> Thanks for the v2 patch, it looks good to me.
>
> Acked-by: Kazuhito Hagio <[email protected]>
>

Thank you for the improvement, Shijie. For the v2, applied.


> > ---
> >  arm64.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arm64.c b/arm64.c
> > index 4f2c2b5..de1038a 100644
> > --- a/arm64.c
> > +++ b/arm64.c
> > @@ -4170,6 +4170,11 @@ arm64_calc_VA_BITS(void)
> >                       } else if (machdep->machspec->VA_BITS_ACTUAL) {
> >                               machdep->machspec->VA_BITS =
> machdep->machspec->VA_BITS_ACTUAL;
> >                               machdep->machspec->VA_START =
> _VA_START(machdep->machspec->VA_BITS_ACTUAL);
> > +                     } else if
> (machdep->machspec->CONFIG_ARM64_VA_BITS) {
> > +                             /* guess */
> > +                             machdep->machspec->VA_BITS_ACTUAL =
> > machdep->machspec->CONFIG_ARM64_VA_BITS;
> > +                             machdep->machspec->VA_BITS =
> machdep->machspec->CONFIG_ARM64_VA_BITS;
> > +                             machdep->machspec->VA_START =
> _VA_START(machdep->machspec->VA_BITS_ACTUAL);
> >                       } else
> >                               error(FATAL, "cannot determine
> VA_BITS_ACTUAL\n");
> >               }
> > --
> > 2.30.2
>
>
--
Crash-utility mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/crash-utility

Reply via email to