On Wed, Apr 6, 2022 at 10:08 AM <[email protected]> wrote:
> Date: Wed, 6 Apr 2022 02:07:47 +0000 > From: HAGIO KAZUHITO(?????) <[email protected]> > To: Huang Shijie <[email protected]>, "[email protected]" > <[email protected]> > Cc: "[email protected]" <[email protected]>, > "[email protected]" <[email protected]>, > "[email protected]" <[email protected]>, > "[email protected]" <[email protected]> > Subject: Re: [Crash-utility] [PATCH v2] diskdump: use mmap/madvise to > improve the start-up > Message-ID: > < > tyypr01mb67776d37c6b5f947ebae6750dd...@tyypr01mb6777.jpnprd01.prod.outlook.com > > > > Content-Type: text/plain; charset="iso-2022-jp" > > -----Original Message----- > > 1.) The bitmap of vmcore file can be very big in the server kernel panic, > > such as over 256M. > > > > This patch uses mmap/madvise to improve the read speed > > of the bitmap in the non-FLAT_FORMAT code path. > > > > Use MADV_WILLNEED for madvise, it will trigger read ahead for > > reading the bitmap. > > Thanks for the update. > > With removing the unused variables (will be fixed when merging), > Acked-by: Kazuhito Hagio <[email protected]> > > $ make clean ; make warn > > diskdump.c: In function ?read_dump_header?: > diskdump.c:543:10: warning: unused variable ?bytes_read? > [-Wunused-variable] > ssize_t bytes_read; > ^~~~~~~~~~ > diskdump.c:542:9: warning: unused variable ?len? [-Wunused-variable] > size_t len; > ^~~ > diskdump.c:541:8: warning: unused variable ?bufptr? [-Wunused-variable] > char *bufptr; > ^~~~~~ > This looks good. Applied(with the above fix) and modified patch log. Thanks. Lianbo > As for a second ack, please wait for a while. > Lianbo is taking a leave and will be back soon. > > Thanks, > Kazu >
-- Crash-utility mailing list [email protected] https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
