On Mon, Oct 10, 2022 at 10:16 AM lijiang <liji...@redhat.com> wrote: > On Mon, Oct 10, 2022 at 9:23 AM Kazuhito Hagio <kazuhito.ha...@gmail.com> > wrote: > >> On Sat, Oct 8, 2022 at 12:27 PM lijiang <liji...@redhat.com> wrote: >> >> >> --- a/ppc64.c >> >> +++ b/ppc64.c >> >> @@ -1947,7 +1947,7 @@ ppc64_in_emergency_stack(int cpu, ulong addr, >> bool verbose) >> >> if (cpu < 0 || cpu >= kt->cpus) >> >> return NONE_STACK; >> >> >> >> - if (ms->emergency_sp) { >> >> + if (ms->emergency_sp && ms->emergency_sp[cpu]) { >> > >> > >> > Is it better to use the IS_KVADDR(ms->emergency_sp[cpu]) ? For example: >> > >> > + if (ms->emergency_sp && IS_KVADDR(ms->emergency_sp[cpu]) ) { >> >> Yes, looks better. Please go ahead with this. >> >> > Thanks. Applied. > > > https://github.com/crash-utility/crash/commit/487551488b15fcd135b29990593699a121730219 > >
Ah, I forgot to add the "Fixes Tag ". Sorry. Lianbo >
-- Crash-utility mailing list Crash-utility@redhat.com https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki