On 12/16/2015 09:39 AM, David M Williams wrote:
As of right now, the 'head' of the model is breaking due to invalid
"categories" and the "Gerrit job" is breaking due to invalid "contacts".
@David:
As far as I can see, the failing Gerrit job is a good thing, since it
did vote -1 on an ongoing review, and it helped the other to fix their
contribution before they could merge it.
Where is the CI job highlighting that HEAD is breaking? I'm on
https://hudson.eclipse.org/simrel/job/simrel.neon.runaggregator.BUILD__CLEAN/
and everything is green.
@All:
Like many are already doing, even if you're a SimRel committer and if
you're using the simrel model editor, it's always a good idea to take
advantage of the validation step offered by Gerrit:
https://wiki.eclipse.org/Simrel/Contributing_to_Simrel_Aggregation_Build#Contribute_via_a_Gerrit_review
. When pushing to Gerrit, the model is automatically validated and you
get a -1 when the model is broken (because of your change, or an earlier
one on your branch but that 2nd case isn't frequent), then you can amend
your patch and submit it again until you get a +1 and permission to
merge via Gerrit if everything seems good. This workflow prevents from
breaking "production" branches.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
