I like gerrit for long-running tests so I can start the next task while tests are still running on the server. Running b3 validation in the b3 editor is not what I call a long-running test, I rather feel it convenient to validate locally, before pushing to the server. Does the Gerrit validation job perform additional validations that I don't get in the IDE?
Also my gut feelings says, that if everybody has to go through gerrit, we will see lots of rebase-jobs piling up, just because during one validation job s.o. else has merged his changes and hence other changes cannot be merged before doing a rebase, triggering another validation job etc. I'm not sure if gerrit is perfect for this many concurrent pushes to the same repo in such a short time frame. Stephan On 01/07/2016 12:55 PM, Mickael Istria wrote:
Hi all, Gerrit for SimRel has been widely used by many projects and the validation checks that come with Simrel have successfully caught a bunch of issues before the had the opportunity to break the Simultaneous Release. Gerrit and Code-Review can have an incredible effect on software quality, many projects and teams enforce it with success. I don't have metrics, but maybe David can say whether he felt a noticeable improvement in stability/quality since the inception of Gerrit a few months ago? I believe it's the right time to start considering enforcing Gerrit usage for SimRel: a first implementation would be to have committers push to refs/for/master instead of master, and would either be reviewed by someone else, or review themselves their contribution. The Hudson validation job triggers automatically on any contribution and gives a vote if the contribution is breaking the build. What do you think? -- Mickael Istria Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools> My blog <http://mickaelistria.wordpress.com> - My Tweets <http://twitter.com/mickaelistria> _______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
