Shiliu, the link is invalid, could you check that? FYI, Raphael still has concern about this flag, so is not enabled on bulidbot. CC Ningxin because XDK is main customer of windows platform.
Thanks, Halton. From: Wang, Shiliu Sent: Monday, November 18, 2013 8:54 AM To: Huo, Halton; Menard, Alexis; Oliveira, Caio; Kubo Da Costa, Raphael; Christiansen, Kenneth R; Sanchez-Palencia, Jesus Cc: crosswalk-dev@lists.crosswalk-project.org Subject: RE: Build xwalk with -Dbuildtype=Official And it's not a bug of upstream, referring https://code.google.com/p/chromium/issues/detail?id=319681 . Thanks, Shiliu. From: Huo, Halton Sent: Saturday, November 16, 2013 12:31 PM To: Menard, Alexis; Oliveira, Caio; Kubo Da Costa, Raphael; Christiansen, Kenneth R; Sanchez-Palencia, Jesus Cc: crosswalk-dev@lists.crosswalk-project.org<mailto:crosswalk-dev@lists.crosswalk-project.org>; Wang, Shiliu Subject: Build xwalk with -Dbuildtype=Official Hi Alexis/Kenneth/Caio/Jesus, I'd like to suggest for enable -Dbuildtype=Official for our buildbot, the official release. (trybot won't change). The background is the xwalk static library of chromium 32 based will core dump. After Shiliu's investigation, it is because non official build will replace the DuplicateHandle for test only. Check the code at https://code.google.com/p/chromium/codesearch#chromium/src/content/common/sandbox_win.cc for details. (This issue does not happens on chrome because there are chrome.dll and chrome.exe, while xwalk does not, ask Shiliu for more specific reason). Shiliu and I got two solutions 1. Add a patch to disable the code about the replacing DuplicateHandle 2. build -Dbulidtype=Official Currently, we prefer solution #2 with reasons: 1. No patch for chromium-crosswalk, good for rebase 2. No regression found according my testing. 3. Official build use some special flag to increase build and decrease the binary size. grep Official in .gyp/.gypi to check. Open: If we agree to enable -Dbuildtype=Official, should we enable all platform? So far I tried on windows and linux. Thanks, Halton.
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
