Hi, Few questions :
- The file storage is not crypted? Is it open to read if I let say use the File Manager application on my phone to access. It may not be related but remember all the buzz around Chrome storing your infos in plain text. - We need a runtime flag for that because some apps are not going to want that for various reasons (not storing sensitive information) so we should give a way to disable that support. - Do we support disabling in some ways for specific fields (this may be more a JS/HTML thing)? For example one may not want to store the input value of a credit card so that the completion does not show it afterwards. And this will also make sure that the content is not stored into my completion suggestion of my android keyboard (let say you use Samsung phones or SwitfKey). Overall I think it's more a browser feature than an web app/games feature but I can see few uses cases. Let make sure we can opt-out, this is a very tricky problem. Thanks. On Tue, Nov 26, 2013 at 11:46 PM, Yin, Li <li....@intel.com> wrote: > Thanks. > > > > PR can be found here: > https://github.com/crosswalk-project/crosswalk/pull/1132 > > Comments are welcome. > > > > Regards, > > Li Yin > > > > *From:* Zhu, Yongsheng > *Sent:* Wednesday, November 27, 2013 9:25 AM > *To:* Yin, Li; Ming, Bai; crosswalk-dev@lists.crosswalk-project.org > *Subject:* RE: [Crosswalk-dev] Intent to Implement: [Android] Implement > autocomplete feature for Xwalk > > > > Lgtm. Li, please go ahead. > > > > Yongsheng > > > > *From:* Crosswalk-dev [ > mailto:crosswalk-dev-boun...@lists.crosswalk-project.org<crosswalk-dev-boun...@lists.crosswalk-project.org>] > *On Behalf Of *Yin, Li > *Sent:* Monday, November 25, 2013 2:49 PM > *To:* Ming, Bai; crosswalk-dev@lists.crosswalk-project.org > *Subject:* Re: [Crosswalk-dev] Intent to Implement: [Android] Implement > autocomplete feature for Xwalk > > > > Yes, it supports Xwalk APP. > > > > Currently, I am using “RuntimeContext::GetPath()” to get the default path, > which will be as the destination to store autofill data. > > From the code, it is “DIR_ANDROID_APP_DATA”, which is the same with > Android chrome webview. > > > > Regards, > > Li Yin > > *From:* Crosswalk-dev [ > mailto:crosswalk-dev-boun...@lists.crosswalk-project.org<crosswalk-dev-boun...@lists.crosswalk-project.org>] > *On Behalf Of *Ming, Bai > *Sent:* Monday, November 25, 2013 1:38 PM > *To:* crosswalk-dev@lists.crosswalk-project.org > *Subject:* Re: [Crosswalk-dev] Intent to Implement: [Android] Implement > autocomplete feature for Xwalk > > > > Will it support xwalk application? > If yes, perhaps we need to figure out the best place to store the autofill > data, maybe somewhere under the application's storage. > > - Ming, Bai > > On 11/25/2013 11:16 AM, Yin, Li wrote: > > *Summary:* > > Every time the user submits a form, entries in text input fields organized > by the name of the field specified in html get stored in the database under > the profile. > > When the user opens a webpage containing a form and types into one of the > fields, Xwalk checks the database for past entries into fields with the > same name. > > As the user types, a pop-up menu appears allowing the user to select from > entries which match the prefix already entered. > > > > *Affected component:* N/A > > > > *Related feature: *XWALK-157 < > https://crosswalk-project.org/jira/browse/XWALK-157> > > > > *Target Release:* Crosswalk 3 > > > > *Implementation details*: > > - XWalkSettings class provides set/getSaveFormData API, which can control > the suggestion dialog will be popped up or not. > > - XWalkContent class provides getFormDatabase interface to get an > XWalkFormDatabase object. > > Through XWalkFormDatabase object, developers can call hasFormData() to > check if there is relevant database, and can clear form database through > clearFormData(). > > - In native code side, added followed files to implement auto complete. > > xwalk_autofill_manager_delegate.cc > > xwalk_autofill_manager_delegate.h > > xwalk_form_database.cc > > xwalk_form_database.h > > xwalk_form_database_service.cc > > xwalk_form_database_service.h > > - In java code side, followed files are created: > > XWalkAutofillManagerDelegate.java > > XWalkFormDatabase.java > > > > Regards, > > Li Yin > > > > _______________________________________________ > > Crosswalk-dev mailing list > > Crosswalk-dev@lists.crosswalk-project.org > > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev > > > > _______________________________________________ > Crosswalk-dev mailing list > Crosswalk-dev@lists.crosswalk-project.org > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev > > -- Alexis Menard
_______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
