Hi,
We need to track the overal APK size not just libxwalkcore.so. Say you pack an hello world with make_apk and make sure that the APK (not installed) is sensibly the same as before. The bug I was talking about was packing additional files that it shouldn't thus tracking libxwalkcore.so wouldn't help. This is what matter to our users uploading to the store. For xwalk_core_library (as packaged https://download.01.org/crosswalk/releases/crosswalk/android/canary/8.37.188.0/x86/) I think tracking libxwalkcore.so would make sense. For the APK size I think something>= 1Mb should trigger a bug report for investigation. ________________________________ > From: [email protected] > To: [email protected]; [email protected]; > [email protected]; [email protected] > Date: Tue, 5 Aug 2014 08:48:21 +0000 > CC: [email protected] > Subject: Re: [Crosswalk-dev] Measuring xwalk_core_library size and APKs > size produced by make_apk > > > I believe the xwalk_core_library refers to “libxwalkcore.so” in APK. > > > > I’m OK that we could monitor the “libxwalkcore.so” size in APK, but > what’s the criteria of bug reporting? Like limited delta change, or > total size should not greater than a certain size? > > > > Regarding to the KPI testing (e.g. disk footprint), if the test data > doesn’t match the target, how about change the bug priority to P1? > > > > @Guobing and Xiaodan, any comment? > > > > Thanks, > > Tina > > > > From: Crosswalk-dev > [mailto:[email protected]] On Behalf Of > Jin, Liang > Sent: Tuesday, August 05, 2014 2:05 PM > To: Menard, Alexis > Cc: <[email protected]> > Subject: Re: [Crosswalk-dev] Measuring xwalk_core_library size and APKs > size produced by make_apk > > > > Hi > > In pnp team, the size of XWalkRuntimeLib.apk is being under tracking on > android. The data is far away from target in recently xwalk release. > XWALK-2116<https://crosswalk-project.org/jira/browse/XWALK-2116> shows > the details. > > Category > > > Target > > > Crosswalk Android 8.36.170.0 > > > Crosswalk Android 8.36.165.0 > > > Crosswalk Android 8.36.161.0 > > > Crosswalk Android 8.36.157.0 > > > Crosswalk Android 7.36.154.0 > > > Crosswalk Android 7.36.151.0 > > > Crosswalk Android 7.36.147.0 > > > Crosswalk Android 7.36.146.0 > > > Crosswalk Android 7.35.145.0 > > > Disk Footprint > > > 18 > > > 19.16 > > > 19.16 > > > 19.2 > > > 19.19 > > > 19.2 > > > 19.19 > > > 19.17 > > > 19.17 > > > 18.87 > > > > > The “Disk Foosprint” KPI had been discussed for several rounds during > KPI definition, finally, it’s only asked to be tested on android > platform. > > What’s your mean about “our other released binary”? tracking xwalk > library on Tizen? > > > > Regards > > Liang > > > > -----Original Message----- > From: Crosswalk-dev > [mailto:[email protected]] On Behalf Of > Menard, Alexis > Sent: Saturday, August 2, 2014 1:54 AM > To: > <[email protected]<mailto:[email protected]>> > > Subject: [Crosswalk-dev] Measuring xwalk_core_library size and APKs > size produced by make_apk > > > > Hi, > > > > While working on XWALK-2184, I discovered that make_apk was packing > within the final user APK stuff he shouldn’t pack in the first place, > it was increasing the overall size of the final APK about ~2mb. A PR is > on its way to fix and due to this erroneous packing it was triggering > the bug on XWALK-2184. Later today some brave user running the canary > also told me he saw the size increase. > > > > One drawback of Crosswalk is its payload of ~17mb to publish to the > store. It’s part of our objective to make sure that it doesn’t get too > bad with the time, that’s why I think it’s important to make sure it’s > tracked in our performance or QA reports. Obviously the final APK size > will increase/decrease slightly with the time (due to changes in the > code) but we shouldn’t get big bumps. Something bigger than 1mb is > already a problem and probably needs investigation. > > > > As we’re at it, we should also make sure to track xwalk_core_library > which is our other released binary. Again this is important for our > users. > > > > What you guys think? > > _______________________________________________ > > Crosswalk-dev mailing list > > [email protected]<mailto:[email protected]> > > > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev > > _______________________________________________ Crosswalk-dev mailing > list [email protected] > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
