Hi Jun, Could you send updated version of this Intent so that others can continue on reviewing.
Thanks, Halton. > -----Original Message----- > From: Crosswalk-dev > [mailto:[email protected]] On Behalf Of > Raphael Kubo da Costa > Sent: Tuesday, March 31, 2015 4:07 PM > To: [email protected] > Subject: Re: [Crosswalk-dev] Intent to Implement: LZMA support for Crosswalk > > Some of the questions I asked below still have not been answered as far as I > can tell. > > Raphael Kubo da Costa <[email protected]> writes: > > "Dong, Jun" <[email protected]> writes: > > > >> This use the LZMA library from SevenZip > >> (http://sourceforge.net/projects/sevenzip/files/). > > > > What's the license of this code? Where will it be located? > > > >> The app will firstly extract the compressed library in its package, > >> if it doesn’t found the library or the library is older. > > > > Can you elaborate? So the idea is to compress libxwalkcore.so, > > decompress it once when loading and store the uncompressed version > > somewhere and start using that one? > > > >> Crosswalk will provide a new method(onXWalkReady) for developers to > >> customize their behavior when the decompression is completed. > > > > What kind of customization do you have in mind? At first it sounds > > unnecessary to me. > > > >> Will add a new build flag(use_lzma), by default it is disabled in > >> Crosswalk. > > > > I guess this is related to me not understanding the exact thing you > > are proposing here, but why do we want a build flag if this offers > > clear benefits? Are there any drawbacks you did not mention? > > > >> Risks/Opens: > >> > >> 1. Rebasing may introduce some regression. > > > > Why? Does this introduce changes to chromium-crosswalk? > _______________________________________________ > Crosswalk-dev mailing list > [email protected] > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list [email protected] https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
