Xiaosong, I would have preferred the fallback / force 32bit implemented on the client side, but it's a minor issue. Your explanation makes a lot of sense, thanks.
LGTM. On 19 October 2015 at 03:14, Wei, Xiaosong <xiaosong....@intel.com> wrote: > I would prefer to reuse "xwalk_apk_url" meta-data as > 1) it has been already used in shared mode for from where the runtime Apk > should be downloaded. > 2) the multiple naming in the manifest somehow is redundant, it also makes > crosswalk difficult to determine which one should be used to download the > APK. For example, if developer wants to force his/her application to run into > 32bit process on a 64bit Android platform, if we download an APK from 64bit > URL then the application will fail to run. But if we keep using > "xwalk_apk_url" with query string "?arch=CPU_ABI", developer's server can > send back 32bit runtime APK as he knows for sure his application only runs in > 32bit process. > 3) the multiple architecture support in Apk download is also missing in > shared mode, this will also apply to shared mode. > > Thanks > Xiaosong > > -----Original Message----- > From: Staudinger, Robert [mailto:robert.staudin...@intel.com] > Sent: Thursday, October 15, 2015 9:18 PM > To: Wei, Xiaosong > Cc: crosswalk-dev@lists.crosswalk-project.org; Yu, Zhiqiang; Balestrieri, > Francesco; Sun, Lin; Zhang, Belem; Oda, Terri > Subject: Re: Intent to Implement -- Silent Download Mode for Crosswalk Android > > On 8 October 2015 at 09:23, Wei, Xiaosong <xiaosong....@intel.com> wrote: >> >> Developer need to host XWalkRuntimeLib.apk for different CPU architectures, >> the URL will be appended with a query string “?arch=CPU_ABI” when the >> request is sent to server, where CPU_ABI is exactly the same as the value >> returned from “adb shell getprop ro.product.cpu.abi”, e.g, x86 for x86 >> 32bit, armeabi-v7a for ARM 32bit. >> > > Two comments about this: > 1 - What about namespacing the manifest field, e.g. > <meta-data android:name=”org.xwalk.runtime” > android:value=”http://host/XWalkRuntimeLib.apk” />. > > 2 - If we put all the ABIs in the manifest, it is easier on the servers side, > there does not have to be code serving the right apk, e.g. > <meta-data android:name=”org.xwalk.runtime.x86” > android:value=”http://host/XWalkRuntimeLib.x86.apk” />. > <meta-data android:name=”org.xwalk.runtime.armeabi-v7” > android:value=”http://host/XWalkRuntimeLib.armeabi-v7.apk” /> > <meta-data android:name=”org.xwalk.runtime.x86_64” > android:value=”http://host/XWalkRuntimeLib.x86_64.apk” />. > etc ... > > Then the app can pick and download the one matching the device ABI. > > Otherwise, LGTM. -- Intel GmbH - Registergericht Muenchen HRB 47456 - Dornacher Strasse 1, 85622 Feldkirchen, Germany _______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
