LGTM
On Tue, Nov 3, 2015 at 7:18 AM, Raphael Kubo da Costa <raphael.kubo.da.co...@intel.com> wrote: > "Balestrieri, Francesco" <francesco.balestri...@intel.com> writes: > >> On 03/11/15 14:56, "Crosswalk-dev on behalf of Raphael Kubo da Costa" >> <crosswalk-dev-boun...@lists.crosswalk-project.org on behalf of >> raphael.kubo.da.co...@intel.com> wrote: >> >> >>>"Balestrieri, Francesco" <francesco.balestri...@intel.com> writes: >>> >>>> “make_apk" is a Python script included in the crosswalk distribution >>>> that automates the creation of APKs of Crosswalk-based HTML5 >>>> applications. It is replaced by crosswalk-app-tools and can therefore >>>> be removed if there are no objections. >>>> >>>> Affected component: make_apk and related tests >>>> >>>> Related feature: https://crosswalk-project.org/jira/browse/XWALK-5629 >>>> >>>> Target release: Crosswalk 18 >>>> >>>> Implementation details: Basically this is about removing >>>> https://github.com/crosswalk-project/crosswalk/tree/master/app/tools/android >>>> from the tree and updating all documentation to point to the new tool. >>> >>>When you say "deprecate" you mean "remove", right? How about adding a >>>big warning in Crosswalk 17's make_apk saying it will be deprecated, >>>announcing this deprecation as soon as possible and update the >>>documentation before this happens? This way we'd have everything >>>prepared before Crosswalk 18, and getting rid of it would be simpler. >> >> Agreed > > lgtm+++++++++++++++++++ then :-) > _______________________________________________ > Crosswalk-dev mailing list > Crosswalk-dev@lists.crosswalk-project.org > https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev _______________________________________________ Crosswalk-dev mailing list Crosswalk-dev@lists.crosswalk-project.org https://lists.crosswalk-project.org/mailman/listinfo/crosswalk-dev
