This pull doesn't address the original problem that the network_test_helper.rb is not being copied into the crowbar_framework/test directory as a result of running dev setup-unit-tests or dev reload-unit-tests, whichever is supposed to do it. Rob's temporary hack was to just check in a copy of the file into the crowbar/crowbar_framework/test directory.
-----Original Message----- From: crowbar-bounces On Behalf Of Abes, Andi Sent: Monday, March 04, 2013 3:20 PM To: Allen, Wayne; crowbar Subject: Re: [Crowbar] FW: [Still Failing] crowbar/travis-ci-crowbar#25 (master - 0d171b7) So, I believe this is fixed in this pull https://github.com/crowbar/crowbar/pull/1734 > -----Original Message----- > From: crowbar-bounces On Behalf Of Allen, Wayne > Sent: Monday, March 04, 2013 1:06 PM > To: crowbar > Subject: [Crowbar] FW: [Still Failing] crowbar/travis-ci-crowbar#25 > (master - > 0d171b7) > > Copying list... > > -----Original Message----- > From: Allen, Wayne > Sent: Monday, March 04, 2013 12:06 PM > To: 'Adam Spiers' > Subject: RE: [Crowbar] [Still Failing] crowbar/travis-ci-crowbar#25 > (master - > 0d171b7) > > I haven't looked at it, yet, Adam, working on some other breakage. At > the moment network is the only bc with these tests defined in the > barclamp itself. The engine conversion generates a skeleton test dir, > with a test_helper, and they will have to be namespaced somehow if > they are going to be copied in. I just haven't had time to go there, > yet. Maybe this afternoon? > > Wayne > > -----Original Message----- > From: crowbar-bounces On Behalf Of Adam Spiers > Sent: Monday, March 04, 2013 8:57 AM > To: crowbar > Subject: Re: [Crowbar] [Still Failing] crowbar/travis-ci-crowbar#25 > (master - > 0d171b7) > > [email protected] ([email protected]) wrote: > > This issue is because “dev setup-unit-tests” doesn’t currently copy > > the network helper class into the dev testing area, which it used to > > do before the network barclamp was converted to a rails engine. > > Wayne has a task to fix this in a general way this sprint > > Thanks for the info. Wayne, how is that going to work? Would be > useful to know for my work on Travis and ./dev. > > > but in the interim, Rob has hacked in a temporary fix in this pull: > > > > https://github.com/crowbar/barclamp-crowbar/pull/422 > > which I just reviewed and merged. > > > > Try another run, and you should get past the network barclamp issues > > now… > > Still seeing errors - looking into it now. > > _______________________________________________ > Crowbar mailing list > [email protected] > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ > _______________________________________________ > Crowbar mailing list > [email protected] > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list [email protected] https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list [email protected] https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
