Andi Abes ([email protected]) wrote:
> I think we're talking about a few days, not as an ongoing
> pattern. Surely we're living with much bigger warts than this
> one...;)
Sorry, but TBH I haven't seen much bigger warts in this project ;-)
In my experience the "negative break-even point" for duplicated code
and docs (i.e. the point at which the disadvantages start outweighing
the benefits) is typically hours or days, not weeks, especially when
there are a lot of people working on the project and several of them
(e.g. me) aren't close enough to the core code to confidently
distinguish between new code and retired old code.
One of the major points of using revision control is to eliminate the
need to keep unnecessary code/docs hanging around. It's incredibly
simple to use git to examine the old code, e.g.
$ git tag duplicated
[... remove duplicates, commit, send pull request ...]
$ git show duplicated:crowbar_framework/app/models/network.rb
or
$ git checkout duplicates
or
$ gitk duplicates # and then click on the "Tree" radio button
so I really can't see a good reason to keep it (except of course for
where stuff would still break without it due to the engines migration
not being finished yet).
IIRC the Pragmatic Programmers wrote something like this in their
famous first book:
Don't Repeat Yourself!
This rule is so important that it's worth breaking to show how
important it is.
Don't Repeat Yourself!
;-)
> From: crowbar-bounces On Behalf Of Darrel O'Pry
> Sent: Wednesday, March 13, 2013 3:32 PM
> To: James Tan
> Cc: crowbar; Allen, Wayne
> Subject: Re: [Crowbar] removing non-engine files?
>
>
> I have to second James here. I just came off a project where they insisted on
> keeping historic stuff in the repo. It only served to confuse people coming
> onboard who weren't already familiar with the project. Its really easy to
> make a branch in you own repository and switch back to it or view it on
> github if you need it for reference.
> On Mar 13, 2013 2:04 PM, "James Tan" <[email protected]<mailto:[email protected]>>
> wrote:
> On 03/13/2013 04:54 PM, [email protected]<mailto:[email protected]>
> wrote:
> > I would like to keep the old versions around for quick reference and delete
> > them as each barclamp is fully integrated into the new system.
>
> While I understand the convenience of keeping these files around during
> integration, it's really confusing for everyone else. Can you remove
> them and refer via the git history instead?
>
> Thanks,
> James T.
>
> _______________________________________________
> Crowbar mailing list
> [email protected]<mailto:[email protected]>
> https://lists.us.dell.com/mailman/listinfo/crowbar
> For more information: http://crowbar.github.com/
> _______________________________________________
> Crowbar mailing list
> [email protected]
> https://lists.us.dell.com/mailman/listinfo/crowbar
> For more information: http://crowbar.github.com/
_______________________________________________
Crowbar mailing list
[email protected]
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: http://crowbar.github.com/
