Sounds like a great patch candidate


On Aug 12, 2009, at 3:28 AM, Adam Byrtek <[email protected]> wrote:

On Wed, Aug 12, 2009 at 00:06, Jeremy
Lightsmith<[email protected]> wrote:
I think the idea is that, if you actually want to use this feature, you need to do additional initialization in your cruise_config.rb file. I don't have
it in front of me, but it would be something like :

Project.config do |project|
  project.source_control = Subversion.new(:repository =>
"svn://my.repos...", :user ...)
end

I didn't want to overwrite source_control if it exists so I tried this

  project.source_control.repository = "https://...";

and it works, thanks. Fortunately the user credentials are cached by
the Subversion client.

if all we ever do is svn updates, we don't need this info, and while you do enter it in order to create your project in the first place, cruise doesn't
store it.

I understand that. Looks like all the options that are provided on the
command line are lost after the initial checkout is done. Even the
type of the source control system is auto-detected based on contents
of the work directory.

On the other hand do_clean_checkout is described in the documentation
without any additional comments and when you use it as documented the
effect is as follows

1. The work directory is purged completely.
2. The web interface fails with 500, you cannot even access the main page.

In other words the application is in inconsistent state and the
situation has to be resolved manually.

My proposition to solve this issue would be

1. Get the repository URL from "svn info" (or equivalents in other
SCMs) before the work directory is purged. This file is already parsed
to get some other information so this should be quite easy.
2. Fail gracefully when the work directory doesn't exist.
3. Document it better.

If there are no objections I can start with preparing a patch for 1.

Best regards,
Adam


--
Adam Byrtek
_______________________________________________
Cruisecontrolrb-users mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-users
_______________________________________________
Cruisecontrolrb-users mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-users

Reply via email to