If the discussion is just about using the codestyle then the following comments are irrelevant.
Waiving code quality tools (like Checkstyle , PMD or Findings) "manually" as maven pluggings is usually inefficient and inconsistent compared to tools like: Jenkins + Sonar. Sonar integrates all important quality tools out of the box, provides consistent metrics, reports and management. Apache provides Jenkins not sure about Sonar? Having said this I don't mind using either approach. It is the code that matters and who is looking at it ;) Cheers, Chris On Jun 21, 2012 7:34 AM, "Robert Chu" <[email protected]> wrote: > Using checkstyle with maven has worked well for me in my experience as > well. For those of you who have had a bad experience with the > maven-checkstyle combination, what went wrong? I'd like to have a > checkstyle system that doesn't require developers to use eclipse (I don't > use eclipse for development). > > On Tue, Jun 19, 2012 at 2:01 PM, Tom White <[email protected]> wrote: > >> On Sat, Jun 16, 2012 at 3:27 AM, Gabriel Reid <[email protected]> >> wrote: >> > +1 for a style guide and/or formatting rules and coding rules. >> > >> > For code style, something that I've seen work well (at least if >> everyone is using Eclipse) is to just have a shared code style definition >> that you can import into Eclipse, and then set Eclipse to apply that style >> whenever you save a file. This works great if everyone uses the same style >> definition, and breaks down rapidly if they don't. >> > >> > I don't have any experience using the maven-findbugs-plugin, but I do >> find the Checkstyle useful, as long as the settings are sane (which is not >> always the case). >> >> We've had a good experience with Checkstyle in Apache Whirr. The way >> we have it set up is to fail the package build if there are Checkstyle >> errors. The relevant POM for doing that is at >> http://svn.apache.org/repos/asf/whirr/trunk/pom.xml >> >> Tom >> >> > >> > On Saturday 16 June 2012 at 00:17, Josh Wills wrote: >> > >> >> I'm in favor of a style guide; consistent layout makes it easier for >> >> my brain to devour code. That said, I'm not up-to-date on best >> >> practices here in the real world; my only experience with automated >> >> code review tools was at teh goog. >> >> >> >> Re: code reviews, let's start that discussion up in another thread. >> >> >> >> J >> >> >> >> On Fri, Jun 15, 2012 at 3:13 PM, Robert Chu <[email protected](mailto: >> [email protected])> wrote: >> >> > Hey Everybody, >> >> > >> >> > I'd like to start a discussion about using automated code review >> tools >> >> > to improve the crunch development process. I'd I'm personally a big >> >> > fan of using tools that can help improve code quality. These tools >> >> > often include things like the maven-checkstyle-plugin and the maven- >> >> > findbugs-plugin. I am currently unaware of any comparable scala >> >> > automated tools. If people have opinions on whether or not we should >> >> > use tools like this or which tools we should be using specifically >> >> > please let us know. >> >> > >> >> > Also, another related question: Should we have some sort of a code >> >> > review process? >> >> > >> >> > Robert Chu >> >> >> >> >> >> >> >> -- >> >> Director of Data Science >> >> Cloudera >> >> Twitter: @josh_wills >> > >> > >> > >
