[
https://issues.apache.org/jira/browse/CRUNCH-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426591#comment-13426591
]
Gabriel Reid commented on CRUNCH-29:
------------------------------------
A couple of ideas how this could be improved a bit:
1. Allow the user of the API to provide a separator string instead of making
them choose between no separator or a string (for example, what if I want a
comma-separated string?)
2. Use the Google Guava Joiner instead of custom string joining code
(http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/base/Joiner.html).
The Joiner class does a great job of taking care of edge cases, and will also
provide built-in functionality if we want to filter out null values, etc.
> Add string concatenation in CombineFn
> -------------------------------------
>
> Key: CRUNCH-29
> URL: https://issues.apache.org/jira/browse/CRUNCH-29
> Project: Crunch
> Issue Type: Improvement
> Reporter: Gauthier Ambard
> Priority: Minor
> Labels: newbie
> Attachments: 0001-CRUNCH-29-Patch-adding-string-concatenation.patch
>
>
> Add two methods for string concatenation in CombineFn: one with a space
> acting as a separator between the string, and one without.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
