On Monday, 2012-09-24, Josh Wills wrote: > On Mon, Sep 24, 2012 at 11:09 AM, Matthias Friedrich <[email protected]> wrote: [...] >> I'd say let's remove log4j.properties from Crunch, because users >> can't defend themselves against it. We have local applications at >> work that run some parts locally, without anything Hadoop-specific; >> shipping a log4j.properties with Crunch would cause problems for us. >> We could then add a log4j.properties to src/main/resources in the >> archetype with an explanation of when exactly this configuration is >> used (only when running from the IDE). We would keep enableDebug() >> with its setting of "crunch.debug", but remove the log4j code, and add >> a "provided" log4j dependency to the archetype (because log4j is >> missing from hadoop-core). >> Does this make sense? Will this give you the logging/debugging output >> that you need? > I'm on board with that plan. My one tweak would be to add support for > hacking log4j to turn on Hadoop's WARN > logs into the crunch-test functionality, which I think will serve my > needs from within the IDE and won't interfere with > any production or client log settings. Does that meet your goals as well?
Alright, let's do it then. I'll make a patch right after we're done with the archetype (probably this weekend). Regards, Matthias
