-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8308/
-----------------------------------------------------------

Review request for crunch.


Description
-------

We should add support for the NLineInputFormat and the KeyValueTextInputFormat 
so that all of the InputFormats in hadoop's mapredice.lib.input package are 
supported in Crunch.


This addresses bug CRUNCH-119.
    https://issues.apache.org/jira/browse/CRUNCH-119


Diffs
-----

  crunch/src/it/java/org/apache/crunch/io/CompositePathIterableIT.java 796b821 
  crunch/src/it/java/org/apache/crunch/io/NLineInputIT.java PRE-CREATION 
  crunch/src/it/java/org/apache/crunch/io/TextFileTableIT.java PRE-CREATION 
  crunch/src/main/java/org/apache/crunch/io/ReadableSource.java 73a13a3 
  crunch/src/main/java/org/apache/crunch/io/avro/AvroFileReaderFactory.java 
6f21dd2 
  crunch/src/main/java/org/apache/crunch/io/avro/AvroFileSource.java 2226556 
  crunch/src/main/java/org/apache/crunch/io/impl/AutoClosingIterator.java 
d58f290 
  crunch/src/main/java/org/apache/crunch/io/impl/FileTableSourceImpl.java 
f6e8f1d 
  crunch/src/main/java/org/apache/crunch/io/seq/SeqFileReaderFactory.java 
ad1b81b 
  crunch/src/main/java/org/apache/crunch/io/seq/SeqFileSource.java e8f3dcf 
  crunch/src/main/java/org/apache/crunch/io/seq/SeqFileTableReaderFactory.java 
20c749a 
  crunch/src/main/java/org/apache/crunch/io/seq/SeqFileTableSource.java 56ed985 
  crunch/src/main/java/org/apache/crunch/io/text/LineParser.java PRE-CREATION 
  crunch/src/main/java/org/apache/crunch/io/text/NLineFileSource.java 
PRE-CREATION 
  crunch/src/main/java/org/apache/crunch/io/text/TextFileReaderFactory.java 
a0c48e0 
  crunch/src/main/java/org/apache/crunch/io/text/TextFileSource.java ee51c04 
  crunch/src/main/java/org/apache/crunch/io/text/TextFileTableSource.java 
PRE-CREATION 
  crunch/src/main/java/org/apache/crunch/io/text/TextFileTableSourceTarget.java 
PRE-CREATION 
  crunch/src/main/java/org/apache/crunch/io/text/TextFileTarget.java c7e06d3 
  crunch/src/test/java/org/apache/crunch/io/avro/AvroFileReaderFactoryTest.java 
66863ba 

Diff: https://reviews.apache.org/r/8308/diff/


Testing
-------

Unit and integration on the new sources.


Thanks,

Josh Wills

Reply via email to