[ 
https://issues.apache.org/jira/browse/CRUNCH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510724#comment-13510724
 ] 

Gabriel Reid commented on CRUNCH-124:
-------------------------------------

Nice update, especially having the docs to remind me that the value (and not 
the key) is used when reading a single field from sequence files :-)

I really like the new methods in From and At where you only have to provide the 
class instead of the PType. One small nitpick though -- I noticed that only the 
specific AvroType is supported here (and not generics or reflects). I think 
supporting generics and reflects here in the same way could be useful -- on the 
other hand, it would make an already-big list of static methods even bigger. 
Was that omission intentional?
                
> Javadoc the From, To, and At static methods and add convenience methods for 
> sequenceFiles
> -----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-124
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-124
>             Project: Crunch
>          Issue Type: Improvement
>          Components: IO
>            Reporter: Josh Wills
>         Attachments: CRUNCH-124.patch
>
>
> Aside from org.apache.crunch.*, the o.a.c.io.(From|To|At) methods are among 
> the most user-facing classes we have. We should javadoc them thoroughly and 
> add more convenience methods that make them easier to get started with for 
> new Crunch users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to